-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68744/
-----------------------------------------------------------

(Updated Sept. 18, 2018, 9:35 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Throw exception if the surrogate_key function is used with an execution engine 
other then Tez.


Bugs: HIVE-20536
    https://issues.apache.org/jira/browse/HIVE-20536


Repository: hive-git


Description
-------

Add new function that allows the generation of a surrogate key composed of the 
write id, the task id, and an incremental row id.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 3f538b3 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3309b9b 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 6d7e63e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSurrogateKey.java 
PRE-CREATION 
  
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSurrogateKey.java
 PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out 8d41e78 


Diff: https://reviews.apache.org/r/68744/diff/2/

Changes: https://reviews.apache.org/r/68744/diff/1-2/


Testing
-------

Added a new junit test for the function.
Tested it in beeline by adding one row, adding multiple rows, adding mutliple 
rows to multiple tables via multuple insert (all having their own surrogate_key 
column)


Thanks,

Miklos Gergely

Reply via email to