Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

> On May 14, 2018, 7:07 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 2545 (patched) > > > > > > Why not LOG.error? > > P

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

> On May 14, 2018, 7:07 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 2545 (patched) > > > > > > Why not LOG.error? My or

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/#review203055 --- Fix it, then Ship it! LGTM. Thanks for making this change. This

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/#review203011 --- Ship it! Ship It! - Alexander Kolbasov On May 11, 2018, 2:13

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/ --- (Updated May 11, 2018, 2:13 p.m.) Review request for hive, Alexander Kolbasov,

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

> On May 10, 2018, 11:49 a.m., Alexander Kolbasov wrote: > > Do you have some way of testing that all the objects are actually deleted > > from the DB? I will create an followup jira to find a way to do this. HIVE-19503 > On May 10, 2018, 11:49 a.m., Alexander Kolbasov wrote: > > standalone-m

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/#review202832 --- Do you have some way of testing that all the objects are actually

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/ --- (Updated May 9, 2018, 1 p.m.) Review request for hive, Alexander Kolbasov, Alan

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/ --- (Updated April 26, 2018, 3:58 p.m.) Review request for hive, Alexander Kolbasov