> On May 14, 2018, 7:07 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 2545 (patched) > > <https://reviews.apache.org/r/66800/diff/4/?file=2019957#file2019957line2566> > > > > Why not LOG.error? > > Peter Vary wrote: > My original thought was, that we fall back to JDO solution this case, so > the problem is not fatal. > I think this is why the other cases are using LOG.warn too. > Shall I change here, and other places as well? > > Thanks for the review!
I see, that sounds good to me then. Thanks - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/#review203055 ----------------------------------------------------------- On May 11, 2018, 2:13 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66800/ > ----------------------------------------------------------- > > (Updated May 11, 2018, 2:13 p.m.) > > > Review request for hive, Alexander Kolbasov, Alan Gates, Marta Kuczora, Adam > Szita, and Vihang Karajgaonkar. > > > Bugs: HIVE-6980 > https://issues.apache.org/jira/browse/HIVE-6980 > > > Repository: hive-git > > > Description > ------- > > First version of the patch. > > Splits getPartitionsViaSqlFilterInternal to: > > getPartitionIdsViaSqlFilter - which returns the partition ids > getPartitionsFromPartitionIds - which returns the partition data for the > partitions > Creates dropPartitionsByPartitionIds which drops the partitions by directSQL > commands > > Creates a dropPartitionsViaSqlFilter using getPartitionIdsViaSqlFilter and > dropPartitionsByPartitionIds. > > Modifies the ObjectStore to drop partitions with directsql if possible. > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 56fbfed > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > b0a805f > > > Diff: https://reviews.apache.org/r/66800/diff/4/ > > > Testing > ------- > > Run the TestDropPartition tests, also checked the database manually, that no > object left in the database > > > Thanks, > > Peter Vary > >
