Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-29 Thread Marta Kuczora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50503/ --- (Updated July 29, 2016, 11:01 a.m.) Review request for hive, Aihua Xu and Sergi

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-29 Thread Marta Kuczora
> On July 27, 2016, 3:26 p.m., Aihua Xu wrote: > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFStringToMap.java, > > line 34 > > > > > > Please add @Test annotation for unit tests. > > Zoltan Hai

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-29 Thread Marta Kuczora
> On July 28, 2016, 3:03 p.m., Aihua Xu wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java, > > line 95 > > > > > > I see. You are passing OIs even delimiters are missing and also

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-28 Thread Zoltan Haindrich
> On July 27, 2016, 3:26 p.m., Aihua Xu wrote: > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFStringToMap.java, > > line 34 > > > > > > Please add @Test annotation for unit tests. if you use @Te

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-28 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50503/#review143944 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStrin

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-28 Thread Marta Kuczora
> On July 27, 2016, 3:26 p.m., Aihua Xu wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java, > > line 95 > > > > > > Are line 90- 93 already dealing with null delimiters ? Seems un

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-27 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50503/#review143742 --- There are some extra spaces or tabs on the files. Could you remove

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-27 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50503/#review143738 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStrin

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-27 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50503/#review143736 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStrin