Re: Review Request 40833: HIVE-12471 Secure HS2 web UI with SSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40833/#review109080 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 1

Re: Review Request 40833: HIVE-12471 Secure HS2 web UI with SSL

> On Dec. 2, 2015, 9:23 p.m., Mohit Sabharwal wrote: > > The conditional is reverse, otherwise lgtm Good catch! Will fix. Thanks. > On Dec. 2, 2015, 9:23 p.m., Mohit Sabharwal wrote: > > common/src/java/org/apache/hive/http/HttpServer.java, line 286 > >

Re: Review Request 40833: HIVE-12471 Secure HS2 web UI with SSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40833/#review108725 --- Ship it! The conditional is reverse, otherwise lgtm common/src/j

Re: Review Request 40833: HIVE-12471 Secure HS2 web UI with SSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40833/ --- (Updated Dec. 2, 2015, 8:09 p.m.) Review request for hive, Lefty Leverenz, Szeh

Re: Review Request 40833: HIVE-12471 Secure HS2 web UI with SSL

> On Dec. 2, 2015, 6:41 a.m., Mohit Sabharwal wrote: > > common/src/java/org/apache/hive/http/HttpServer.java, line 280 > > > > > > Nit: b.keyStorePath to determine ssl is not enabled looks bit unclean. > > Maybe ad

Re: Review Request 40833: HIVE-12471 Secure HS2 web UI with SSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40833/#review108613 --- LGTM. Thanks for adding the Builder! Couple of nits. common/src/j

Re: Review Request 40833: HIVE-12471 Secure HS2 web UI with SSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40833/ --- (Updated Dec. 1, 2015, 6:50 p.m.) Review request for hive, Lefty Leverenz, Szeh