Re: Review Request 24137: allow disabling direct sql per query with external metastore

2014-08-11 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24137/ --- (Updated Aug. 11, 2014, 7:37 a.m.) Review request for hive. Changes ---

Re: Review Request 24137: allow disabling direct sql per query with external metastore

2014-08-03 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24137/ --- (Updated Aug. 4, 2014, 2:12 a.m.) Review request for hive. Changes --- A

Re: Review Request 24137: allow disabling direct sql per query with external metastore

2014-08-03 Thread Navis Ryu
> On Aug. 1, 2014, 9:35 a.m., Lars Francke wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 71 > > > > > > Should be named `META_CONFS` There are fields something like "vars" and "metaVars", w

Re: Review Request 24137: allow disabling direct sql per query with external metastore

2014-08-01 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24137/#review49330 --- Code style issues only common/src/java/org/apache/hadoop/hive/conf

Re: Review Request 24137: allow disabling direct sql per query with external metastore

2014-07-31 Thread Navis Ryu
> On July 31, 2014, 9:01 p.m., Sergey Shelukhin wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 395 > > > > > > would it be enough to make it package-visible? It's on IHMSH

Re: Review Request 24137: allow disabling direct sql per query with external metastore

2014-07-31 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24137/#review49290 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.j