> On Aug. 1, 2014, 9:35 a.m., Lars Francke wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 71 > > <https://reviews.apache.org/r/24137/diff/1/?file=646536#file646536line71> > > > > Should be named `META_CONFS`
There are fields something like "vars" and "metaVars", which is static. I also think uppercase names are better for static fields, but also feel that consistency is more important. > On Aug. 1, 2014, 9:35 a.m., Lars Francke wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 161 > > <https://reviews.apache.org/r/24137/diff/1/?file=646536#file646536line161> > > > > Should be named `META_CONF_VARS` > > > > Also all the `HiveConf` qualifiers are not necessary > > > > Indentation is 2 not 4 as per the Wiki Same as above. > On Aug. 1, 2014, 9:35 a.m., Lars Francke wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java, > > line 63 > > <https://reviews.apache.org/r/24137/diff/1/?file=646546#file646546line63> > > > > no need to call getConf() here To make that same form with other invocations in the class. Just for consistency. - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24137/#review49330 ----------------------------------------------------------- On July 31, 2014, 1:34 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24137/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 1:34 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7532 > https://issues.apache.org/jira/browse/HIVE-7532 > > > Repository: hive-git > > > Description > ------- > > Currently with external metastore, direct sql can only be disabled via > metastore config globally. Perhaps it makes sense to have the ability to > propagate the setting per query from client to override the metastore > setting, e.g. if one particular query causes it to fail. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3bfc681 > common/src/java/org/apache/hadoop/hive/conf/SystemVariables.java ee98d17 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java > 9e416b5 > metastore/if/hive_metastore.thrift 55f41db > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 5cc1cd8 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > d26183b > metastore/src/java/org/apache/hadoop/hive/metastore/IHMSHandler.java > 1675751 > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 5add436 > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java > c28c46a > metastore/src/java/org/apache/hadoop/hive/metastore/RawStoreProxy.java > 1cf09d4 > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java > 86172b9 > > metastore/src/java/org/apache/hadoop/hive/metastore/events/ConfigChangeEvent.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/24137/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
