Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-11 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/ --- (Updated July 12, 2014, 2:18 a.m.) Review request for hive. Changes ---

Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-11 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/ --- (Updated July 11, 2014, 9:16 p.m.) Review request for hive. Changes ---

Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-10 Thread Ashish Singh
> On July 10, 2014, 8:13 p.m., David Chen wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSchemaGenerator.java, > > line 34 > > > > > > It might be better to call this TypeInfoToSchema to make it consi

Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-10 Thread Ashish Singh
> On July 10, 2014, 8:13 p.m., David Chen wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSchemaGenerator.java, > > line 34 > > > > > > It might be better to call this TypeInfoToSchema to make it consi

Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-10 Thread Ashish Singh
> On July 10, 2014, 8:28 p.m., Brock Noland wrote: > > ql/src/test/queries/clientpositive/avro_decimal_native.q, line 13 > > > > > > I think we can remove COMMENT 'from deserializer' as well. > > > > Thx!! Ye

Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-10 Thread Ashish Singh
> On July 10, 2014, 3:01 p.m., Brock Noland wrote: > > I *love* this patch! Thank you so much. Thanks! > On July 10, 2014, 3:01 p.m., Brock Noland wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSchemaGenerator.java, > > line 34 > >

Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-10 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/#review47612 --- ql/src/test/queries/clientpositive/avro_decimal_native.q

Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-10 Thread David Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/#review47609 --- serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSchemaGenerat

Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-10 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/#review47568 --- I *love* this patch! Thank you so much. serde/src/java/org/apache/

Re: Review Request 23387: HIVE-6806: Native Avro support in Hive

2014-07-09 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/ --- (Updated July 10, 2014, 4:50 a.m.) Review request for hive. Changes ---