> On July 10, 2014, 8:28 p.m., Brock Noland wrote: > > ql/src/test/queries/clientpositive/avro_decimal_native.q, line 13 > > <https://reviews.apache.org/r/23387/diff/1/?file=627556#file627556line13> > > > > I think we can remove COMMENT 'from deserializer' as well. > > > > Thx!!
Yes, it is redundant and we will be better without it. Will do. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/#review47612 ----------------------------------------------------------- On July 10, 2014, 4:50 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23387/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 4:50 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6806 > https://issues.apache.org/jira/browse/HIVE-6806 > > > Repository: hive-git > > > Description > ------- > > HIVE-6806: Native Avro support in Hive > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 75394f3bc4f2285a7ced97ea90788d5bbff6b563 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 6cd1f39df3d419651755c35aab7cfc06833b16a4 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g > 412a046488eaea42a6416c7cbd514715d37e249f > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g > f934ac4e3b736eed1b3060fa516124c67f9a2f87 > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g > 9c001c1495b423c19f3fa710c74f1bb1e24a08f4 > ql/src/test/queries/clientpositive/avro_compression_enabled_native.q > PRE-CREATION > ql/src/test/queries/clientpositive/avro_decimal_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_joins_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_partitioned_native.q PRE-CREATION > ql/src/test/results/clientpositive/avro_compression_enabled_native.q.out > PRE-CREATION > ql/src/test/results/clientpositive/avro_decimal_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_joins_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_partitioned_native.q.out > PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSchemaGenerator.java > PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java > 1fe31e0034f8988d03a0c51a90904bb93e7cb157 > > Diff: https://reviews.apache.org/r/23387/diff/ > > > Testing > ------- > > Added qTests > > > Thanks, > > Ashish Singh > >
