Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-10 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17769/#review34088 --- Ship it! The functionality looks good. Please address the minor iss

Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-07 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17769/ --- (Updated Feb. 8, 2014, 6:15 a.m.) Review request for hive and Eric Hanson. Bu

Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-07 Thread Jitendra Pandey
> On Feb. 7, 2014, 10:41 p.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java, > > line 329 > > > > > > > > Because TypeInfo has decimal precision/scale, the ou

Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-07 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17769/#review33942 --- Overall this looks good. Please see my specific comments. I did find

Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-06 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17769/ --- (Updated Feb. 7, 2014, 2:31 a.m.) Review request for hive and Eric Hanson. Ch

Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-05 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17769/ --- (Updated Feb. 6, 2014, 12:42 a.m.) Review request for hive and Eric Hanson. B