----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17769/#review34088 -----------------------------------------------------------
Ship it! The functionality looks good. Please address the minor issues about the comments that I pointed out. No need for me to do another review. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java <https://reviews.apache.org/r/17769/#comment64058> there -> their ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java <https://reviews.apache.org/r/17769/#comment64060> Please add comment before method explaining what it does. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java <https://reviews.apache.org/r/17769/#comment64059> loose -> lose - Eric Hanson On Feb. 8, 2014, 6:15 a.m., Jitendra Pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17769/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2014, 6:15 a.m.) > > > Review request for hive and Eric Hanson. > > > Bugs: HIVE-6333 > https://issues.apache.org/jira/browse/HIVE-6333 > > > Repository: hive-git > > > Description > ------- > > Generate vectorized plan for decimal expressions. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 29c5168 > > ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumnDecimal.txt > 699b7c5 > > ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalarDecimal.txt > 99366ca > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumnDecimal.txt > 2aa4152 > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalarDecimal.txt > 2e84334 > > ql/src/gen/vectorization/ExpressionTemplates/ScalarArithmeticColumnDecimal.txt > 9578d34 > ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumnDecimal.txt > 6ee9d5f > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java > 1c70387 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > f5ab731 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java > f513188 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/AbstractFilterStringColLikeStringScalar.java > 4510368 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToBoolean.java > 6a7762d > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToDecimal.java > 14b91e1 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToDouble.java > 2ba1509 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToLong.java > 65a804d > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToString.java > 5b2a658 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDoubleToDecimal.java > 14e30c3 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastLongToDecimal.java > 1d4d84d > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDecimal.java > 41762ed > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastTimestampToDecimal.java > 37e92e1 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ConstantVectorExpression.java > cac1d80 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColRegExpStringScalar.java > 93052a1 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncDoubleToDecimal.java > 8b2a6f0 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncLongToDecimal.java > 18d1dbb > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpression.java > d00d99b > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpressionWriter.java > e5c3aa4 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpressionWriterFactory.java > a242fef > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > ad96fa5 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 4f59125 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java e4dfcc9 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 4e2d1d4 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 6f9746c > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java e794e92 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 4e64d47 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java > 9a04e81 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqual.java > 3479b13 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrGreaterThan.java > edb1bf8 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrLessThan.java > 06d9647 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPGreaterThan.java > 28bce88 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPLessThan.java > 9258b43 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java > 6ee6f39 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java > e7a2a8d > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNotEqual.java > 4c11e5b > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java > 26ac65c > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java > 454a02d > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java > 4f1169c > ql/src/test/queries/clientpositive/vector_decimal_expressions.q > PRE-CREATION > ql/src/test/queries/clientpositive/vectorization_decimal_date.q > PRE-CREATION > ql/src/test/results/clientpositive/vector_decimal_expressions.q.out > PRE-CREATION > ql/src/test/results/clientpositive/vectorization_decimal_date.q.out > PRE-CREATION > ql/src/test/results/clientpositive/vectorization_short_regress.q.out > 305d336 > > Diff: https://reviews.apache.org/r/17769/diff/ > > > Testing > ------- > > > Thanks, > > Jitendra Pandey > >
