Re: Review Request: alter table concatenate fails and deletes data

2011-04-26 Thread Yongqiang He
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/665/ --- (Updated 2011-04-26 22:27:30.586885) Review request for hive. Changes ---

Re: Review Request: alter table concatenate fails and deletes data

2011-04-25 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/665/#review560 --- trunk/conf/hive-default.xml

Re: Review Request: alter table concatenate fails and deletes data

2011-04-25 Thread Yongqiang He
> On 2011-04-26 05:33:19, Carl Steinbach wrote: > > trunk/ql/src/test/queries/clientpositive/alter_merge_index.q, line 1 > > > > > > Please add some comments here too. Carl, what kind of comments do you want here? > On 2

Re: Review Request: alter table concatenate fails and deletes data

2011-04-25 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/665/#review557 --- trunk/conf/hive-default.xml

Re: Review Request: alter table concatenate fails and deletes data

2011-04-25 Thread Yongqiang He
> On 2011-04-25 23:20:59, Ning Zhang wrote: > > trunk/conf/hive-default.xml, line 1042 > > > > > > can you make the indentation consistent with the other property > > elements? It shows the same indentation on my local.

Re: Review Request: alter table concatenate fails and deletes data

2011-04-25 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/665/#review554 --- trunk/conf/hive-default.xml