----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/665/#review560 -----------------------------------------------------------
trunk/conf/hive-default.xml <https://reviews.apache.org/r/665/#comment1187> Besides describing the effect of this configuration property, can you also please explain the motivation? Why would the user want to set this to true? Is there a valid reason for setting it to false? trunk/ql/src/test/queries/clientnegative/alter_merge_index.q <https://reviews.apache.org/r/665/#comment1183> > Should we explain all test cases in client negative dir? Emphatically yes! And since I'm a helpful person I'll even write the comment for you: "Verify that an error is thrown if the user attempts to concatenate an indexed table when hive.exec.concatenate.check.index=true" Also, please explicitly set hive.exec.concatenate.check.index=true at the beginning of this test. Also, please change the name of this file and the name of the table so that it matches the semantics of the ALTER TABLE command, i.e. alter_concatenate_indexed_table.q and src_rc_concatenate_test. trunk/ql/src/test/queries/clientpositive/alter_merge_index.q <https://reviews.apache.org/r/665/#comment1186> How about this: * Verify that an indexed table can be concatenated when hive.exec.concatenate.check.index=false. * Verify that a partitioned table can be concatenated when hive.exec.concatenate.check.index=false. The point of the comments is help the reader distinguish between details that are relevant to the intended purpose of the test from those that are not. trunk/ql/src/test/queries/clientpositive/alter_merge_index.q <https://reviews.apache.org/r/665/#comment1188> Please replace "merge" with "concatenate". A better name for this test would be "alter_concatenate_indexed_table.q" trunk/ql/src/test/queries/clientpositive/alter_merge_index.q <https://reviews.apache.org/r/665/#comment1185> These tables get cleaned up automatically. Please remove the drop statements. - Carl On 2011-04-25 22:47:17, Yongqiang He wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/665/ > ----------------------------------------------------------- > > (Updated 2011-04-25 22:47:17) > > > Review request for hive. > > > Summary > ------- > > alter table concatenate fails and deletes data > > It is because the number of reducers is set to -1. > > In this patch, it is set to zero. > > Also added a move task as the child task of the merge task. added a conf to > control whether to check index or not, and add the job name for the merge job. > > > This addresses bug HIVE-2125. > https://issues.apache.org/jira/browse/HIVE-2125 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1096599 > trunk/conf/hive-default.xml 1096599 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1096599 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1096599 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java > 1096599 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1096599 > trunk/ql/src/test/queries/clientnegative/alter_merge_index.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/alter_merge_index.q PRE-CREATION > trunk/ql/src/test/results/clientnegative/alter_merge_index.q.out > PRE-CREATION > trunk/ql/src/test/results/clientpositive/alter_merge_index.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/665/diff > > > Testing > ------- > > > Thanks, > > Yongqiang > >
