Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-20 Thread Syed Albiz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/ --- (Updated 2011-06-21 02:50:57.581129) Review request for hive and John Sichi. Ch

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-15 Thread Syed Albiz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/ --- (Updated 2011-06-16 02:32:20.778571) Review request for hive and John Sichi. Ch

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-15 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/#review847 --- ql/src/test/queries/clientpositive/type_widening.q

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-14 Thread Syed Albiz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/ --- (Updated 2011-06-15 00:27:01.842091) Review request for hive and John Sichi. Ch

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-14 Thread Syed Albiz
> On 2011-06-14 19:14:04, John Sichi wrote: > > Wouldn't it be better to change COALESCE to just check that the two objects > > have the same type family (both numeric)? That's what happens in standard > > SQL, and then the widest type is used for the result. This is what UNION > > ALL shoul

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-14 Thread John Sichi
> On 2011-06-14 19:14:04, John Sichi wrote: > > Wouldn't it be better to change COALESCE to just check that the two objects > > have the same type family (both numeric)? That's what happens in standard > > SQL, and then the widest type is used for the result. This is what UNION > > ALL shoul

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-14 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/#review834 --- Wouldn't it be better to change COALESCE to just check that the two obje

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-14 Thread Syed Albiz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/ --- (Updated 2011-06-14 19:04:53.630834) Review request for hive and John Sichi. Ch

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-13 Thread Syed Albiz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/ --- (Updated 2011-06-13 23:32:55.134796) Review request for hive and John Sichi. Ch

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-13 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/#review829 --- ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java <

Re: Review Request: HIVE-872: Allow BIGINT constants

2011-06-13 Thread Syed Albiz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/ --- (Updated 2011-06-13 22:41:25.002039) Review request for hive and John Sichi. Ch