-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/889/
-----------------------------------------------------------
(Updated 2011-06-14 19:04:53.630834)
Review request for hive and John Sichi.
Changes
-------
After talking to jhsu about this, looks like the motivation for this is to
provide a way to coerce int literals into bigints for UDFs that expect
arguments of the same type. E.g. COALESCE(0, 1152921504606846976) will
currently fail. With this updated patch, COALESCE(0L, 1152921504606846976)
passes.
Summary
-------
Added a rule to the lexical grammar to allow BIGINT constants ending with 'L',
and a clause to the TypeCheckProcFactory to ensure it gets interpreted properly.
This addresses bug HIVE-872.
https://issues.apache.org/jira/browse/HIVE-872
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 9161319
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java dfadb9f
ql/src/test/queries/clientpositive/bigint_const.q PRE-CREATION
ql/src/test/results/clientpositive/bigint_const.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/889/diff
Testing
-------
TestCliDriver passes, previous behaviour was to accept bigint constants
specified without 'L', which is also preserved, so adding additional tests for
this case seems unnecessary.
Thanks,
Syed
