Re: Review Request: HIVE-3528

2013-01-08 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7431/#review15161 --- Ship it! +1. Looks great. - Jakob Homan On Jan. 2, 2013, 11:11 p

Re: Review Request: HIVE-3528

2013-01-02 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7431/ --- (Updated Jan. 2, 2013, 11:11 p.m.) Review request for hive and Jakob Homan. Ch

Re: Review Request: HIVE-3528

2012-10-16 Thread Sean Busbey
> On Oct. 9, 2012, 1:06 a.m., Jakob Homan wrote: > > /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java, > > line 97 > > > > > > Good optimization on the null check. Any reason not to put it a

Re: Review Request: HIVE-3528

2012-10-16 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7431/ --- (Updated Oct. 16, 2012, 1:08 p.m.) Review request for hive. Changes --- U

Re: Review Request: HIVE-3528

2012-10-08 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7431/#review12257 --- /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSeriali

Re: Review Request: HIVE-3528

2012-10-05 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7431/ --- (Updated Oct. 5, 2012, 8:39 a.m.) Review request for hive. Changes --- Sp

Re: Review Request: HIVE-3528

2012-10-04 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7431/ --- (Updated Oct. 5, 2012, 3:23 a.m.) Review request for hive. Changes --- WI