----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7431/#review12257 -----------------------------------------------------------
/trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java <https://reviews.apache.org/r/7431/#comment26006> May as well make this static as well. /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java <https://reviews.apache.org/r/7431/#comment26007> Good optimization on the null check. Any reason not to put it as the first check in the method and potentially save the trip to the AvroSerde methods? - Jakob Homan On Oct. 5, 2012, 8:39 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7431/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2012, 8:39 a.m.) > > > Review request for hive. > > > Description > ------- > > Changes AvroSerDe to properly give the non-null schema to serialization > routines when using Nullable complex types > > > Diffs > ----- > > > /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java > 1394121 > > /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java > 1394121 > > Diff: https://reviews.apache.org/r/7431/diff/ > > > Testing > ------- > > Adds tests that check each of the Avro types that Serialization needs to use > a user-provided schema, both as top level fields and as nested members of a > complex type. > > > Thanks, > > Sean Busbey > >
