Re: Review Request: HIVE-2026. Parallelize UpdateInputAccessTimeHook

2011-03-03 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/460/ --- (Updated 2011-03-03 23:25:14.655675) Review request for hive. Changes ---

Re: Review Request: HIVE-2026. Parallelize UpdateInputAccessTimeHook

2011-03-03 Thread Ning Zhang
It looks good to me. Thanks! On Mar 3, 2011, at 10:18 PM, ಕರಿಯ wrote: Hi, Ning 1) You are right on this. But, here the keepAliveTime will not be having much of prominence as the core pool size itself is nThreads and the max pool size is also nThreads. So, even if the threads are idle, nThre

Re: Review Request: HIVE-2026. Parallelize UpdateInputAccessTimeHook

2011-03-03 Thread ಕರಿಯ
Hi, Ning 1) You are right on this. But, here the keepAliveTime will not be having much of prominence as the core pool size itself is nThreads and the max pool size is also nThreads. So, even if the threads are idle, nThreads will always remain in the pool that is created to process the tasks. Al

Re: Review Request: HIVE-2026. Parallelize UpdateInputAccessTimeHook

2011-03-03 Thread Ning Zhang
Hi MIS, Thanks for the contribution! To allow broader audience to review, can you upload your patch to the JIRA and the review board (I can help you with the review board if it doesn't allow you to change the request). A couple of comments before uploading your patch: 1) the 5 sec keepAliveTim

Re: Review Request: HIVE-2026. Parallelize UpdateInputAccessTimeHook

2011-03-03 Thread MIS
Hi, Ning Just to be clear on what I was suggesting, I have created a patch only for this file. Please have a look. Thanks, MIS. On Thu, Mar 3, 2011 at 5:50 PM, M IS wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/460/ > > trunk/ql/src/jav

Re: Review Request: HIVE-2026. Parallelize UpdateInputAccessTimeHook

2011-03-03 Thread M IS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/460/#review283 --- trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTime