----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/460/#review283 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java <https://reviews.apache.org/r/460/#comment534> How about going for a centralized thread pool and submitting the tasks for that pool. This can have advantages like, we need not have to create threads and we could come to know of the status of the task submitted through the future object. And use this future to to wait till the task is finished. We can re factor the code to make UpdateWorker to implement Runnable instead of extending of Thread. - M On 2011-03-03 00:53:49, Ning Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/460/ > ----------------------------------------------------------- > > (Updated 2011-03-03 00:53:49) > > > Review request for hive. > > > Summary > ------- > > define hive.hooks.parallel.degree to control max # of thread to update > metastore in parallel. > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1076459 > trunk/conf/hive-default.xml 1076459 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1076459 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java > 1076459 > > Diff: https://reviews.apache.org/r/460/diff > > > Testing > ------- > > > Thanks, > > Ning > >
