Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-09-10 Thread Prajakta Kalmegh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1194/ --- (Updated 2011-09-10 21:10:06.178279) Review request for hive and John Sichi. C

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-09-08 Thread Prajakta Kalmegh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1194/ --- (Updated 2011-09-09 01:14:16.218940) Review request for hive and John Sichi. S

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-09-07 Thread Prajakta Kalmegh
> On 2011-08-05 21:20:21, John Sichi wrote: > > ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java, > > line 172 > > > > > > See recent changes in corresponding CompactIndexHandler code for > > HIVEO

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-08-05 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1194/#review1303 --- ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.jav

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-08-03 Thread Prajakta Kalmegh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1194/ --- (Updated 2011-08-03 10:31:42.024369) Review request for hive and John Sichi. C

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-08-01 Thread John Sichi
> On 2011-07-28 21:40:30, John Sichi wrote: > > ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java, > > line 61 > > > > > > Please run ant checkstyle and fix all the formatting discrepancies it > > re

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-08-01 Thread Prajakta Kalmegh
> On 2011-07-28 21:40:30, John Sichi wrote: > > ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java, > > line 61 > > > > > > Please run ant checkstyle and fix all the formatting discrepancies it > > re

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-07-28 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1194/#review1212 --- ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.jav

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-03-17 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/505/#review339 --- ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-02-28 Thread John Sichi
> On 2011-02-27 15:49:28, John Sichi wrote: > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/RewriteGBUsingIndex.java, > > line 19 > > > > > > For HIVE-1644, the HMC team is cr

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-02-27 Thread Prajakta Kalmegh
> On 2011-02-27 15:49:28, John Sichi wrote: > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/RewriteCanApplyCtx.java, > > line 121 > > > > > > I don't understand why these sta

Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes

2011-02-27 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/392/#review217 --- http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/h