> On 2011-08-05 21:20:21, John Sichi wrote: > > ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java, > > line 172 > > <https://reviews.apache.org/r/1194/diff/2/?file=30443#file30443line172> > > > > See recent changes in corresponding CompactIndexHandler code for > > HIVEOPTINDEXFILTER; need the same here (or better, factor out common code > > here and elsewhere). > > > > On a related note, you may be able to use the same technique instead of > > isQueryInsertToTable; this would be preferable since it's nice to be able > > to use the index rewrite in cases where it's a normal INSERT table with > > index being used for GROUP BY on SELECT from some other table. > >
I have factored out the common code in all Index handler classes and placed it in IndexUtils file. I also removed the code for "isQueryInsertToTable" and am setting the HIVEOPTINDEXFILTER to false instead. > On 2011-08-05 21:20:21, John Sichi wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java, > > line 153 > > <https://reviews.apache.org/r/1194/diff/2/?file=30449#file30449line153> > > > > Shouldn't this be the same as COUNT(*)? > > Yes it is. I missed to change this part from the previous code. - Prajakta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1194/#review1303 ----------------------------------------------------------- On 2011-08-03 10:31:42, Prajakta Kalmegh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1194/ > ----------------------------------------------------------- > > (Updated 2011-08-03 10:31:42) > > > Review request for hive and John Sichi. > > > Summary > ------- > > This patch has defined a new AggregateIndexHandler which is used to optimize > the query plan for groupby queries. > > > This addresses bug HIVE-1694. > https://issues.apache.org/jira/browse/HIVE-1694 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b46976f > ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndex.java 591c9ff > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java a57f9cf > ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 590d69a > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyCtx.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java > 8295687 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java > 699519b > ql/src/test/queries/clientpositive/ql_rewrite_gbtoidx.q PRE-CREATION > ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/1194/diff > > > Testing > ------- > > > Thanks, > > Prajakta > >
