[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823189#comment-13823189
]
Lefty Leverenz commented on HIVE-5191:
--
[~lars_francke] documented char in the Types d
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814544#comment-13814544
]
Xuefu Zhang commented on HIVE-5191:
---
+1, patch look good to me.
> Add char data type
> -
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814503#comment-13814503
]
Xuefu Zhang commented on HIVE-5191:
---
[~jdere] Thanks for asking my opinion. I think the p
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814484#comment-13814484
]
Jason Dere commented on HIVE-5191:
--
[~xuefuz], you're now a committer! Given that you've s
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811834#comment-13811834
]
Hive QA commented on HIVE-5191:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811097#comment-13811097
]
Hive QA commented on HIVE-5191:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810942#comment-13810942
]
Xuefu Zhang commented on HIVE-5191:
---
Personally I think 255 might be sufficient, and I'd
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810893#comment-13810893
]
Jason Dere commented on HIVE-5191:
--
Standard only says that it is implementation defined:
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810883#comment-13810883
]
Ashutosh Chauhan commented on HIVE-5191:
Max length currently is 255. Seems like di
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810847#comment-13810847
]
Xuefu Zhang commented on HIVE-5191:
---
[~jdere] Thanks for making those changes. I left a m
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809740#comment-13809740
]
Hive QA commented on HIVE-5191:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808576#comment-13808576
]
Xuefu Zhang commented on HIVE-5191:
---
Hi [~jdere], I have some comments on rb on your late
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807697#comment-13807697
]
Xuefu Zhang commented on HIVE-5191:
---
[~jdere] Thanks for the patch. It looks very good. I
[
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807194#comment-13807194
]
Jason Dere commented on HIVE-5191:
--
review at https://reviews.apache.org/r/14998/
> Add c
14 matches
Mail list logo
