[ 
https://issues.apache.org/jira/browse/HIVE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808576#comment-13808576
 ] 

Xuefu Zhang commented on HIVE-5191:
-----------------------------------

Hi [~jdere], I have some comments on rb on your latest patch. After I played 
with your patch, I felt that neither characterLength nor maxLength is  
necessary. The reason for no need of maxLength is that you will always have 
type info because the grammar prevents one from specifying a type of char w/o 
maxLength. This is different from HiveDecimal, where UDF can specifies a return 
type w/o precision/scale, for which some default values have to be assumed.  
Please let me know what you think. Thanks.

> Add char data type
> ------------------
>
>                 Key: HIVE-5191
>                 URL: https://issues.apache.org/jira/browse/HIVE-5191
>             Project: Hive
>          Issue Type: New Feature
>          Components: Types
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-5191.1.patch, HIVE-5191.2.patch
>
>
> Separate task for char type, since HIVE-4844 only adds varchar



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to