-CREATION
Diff: https://reviews.apache.org/r/65478/diff/8/
Changes: https://reviews.apache.org/r/65478/diff/7-8/
Testing
---
Newly added UT passed and qtest passed locally.
Thanks,
cheng xu
-CREATION
Diff: https://reviews.apache.org/r/65478/diff/7/
Changes: https://reviews.apache.org/r/65478/diff/6-7/
Testing
---
Newly added UT passed and qtest passed locally.
Thanks,
cheng xu
-CREATION
Diff: https://reviews.apache.org/r/65478/diff/6/
Changes: https://reviews.apache.org/r/65478/diff/5-6/
Testing
---
Newly added UT passed and qtest passed locally.
Thanks,
cheng xu
be we should add a TODO here to use default precision and
> > scale if its not available for the future.
>
> cheng xu wrote:
> Why do we need the default precision and scale here? We can hardly read
> data as decimal if those values are missing.
>
> Vihang Karajgaonka
-CREATION
Diff: https://reviews.apache.org/r/65478/diff/5/
Changes: https://reviews.apache.org/r/65478/diff/4-5/
Testing
---
Newly added UT passed and qtest passed locally.
Thanks,
cheng xu
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65478/#review197313
---
On Feb. 12, 2018, 4:25 p.m., cheng xu wrote:
>
> -
://reviews.apache.org/r/65478/diff/3-4/
Testing
---
Newly added UT passed and qtest passed locally.
Thanks,
cheng xu
/r/65478/diff/2-3/
Testing
---
Newly added UT passed and qtest passed locally.
Thanks,
cheng xu
s parquet;
> > insert into test_alter2 values ('2018-01-01 13:14:15.123456'),
> > ('2018-01-02 14:15:16.123456'), ('2018-01-03 16:17:18.123456');
> > select * from test_alter2;
> > alter table test_alter2
r(25);
> > select * from test_alter2;
I test non vectorization path and all of these test cases failed due to not
abled to type cast error. Any thoughts on this?
- cheng
---
This is an automatically generated e-mail. To reply,
from the
order of generated files.
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65478/#review196718
---
On Feb. 5, 2018, 4:46 p.m
/clientpositive/schema_evol_par_vec_table.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/65478/diff/2/
Changes: https://reviews.apache.org/r/65478/diff/1-2/
Testing
---
Newly added UT passed and qtest passed locally.
Thanks,
cheng xu
---
Newly added UT passed and qtest passed locally.
Thanks,
cheng xu
: https://reviews.apache.org/r/63711/diff/7/
Changes: https://reviews.apache.org/r/63711/diff/6-7/
Testing
---
Qtest Added locally passed.
Thanks,
cheng xu
; how come data values are changing here?
So the same as above.
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63711/#review191092
-------
://reviews.apache.org/r/63711/diff/5-6/
Testing
---
Qtest Added locally passed.
Thanks,
cheng xu
/temp_table_truncate.q.out b1af432
Diff: https://reviews.apache.org/r/63711/diff/5/
Changes: https://reviews.apache.org/r/63711/diff/4-5/
Testing
---
Qtest Added locally passed.
Thanks,
cheng xu
: https://reviews.apache.org/r/63711/diff/3-4/
Testing
---
Qtest Added locally passed.
Thanks,
cheng xu
: https://reviews.apache.org/r/63711/diff/2-3/
Testing
---
Qtest Added locally passed.
Thanks,
cheng xu
://reviews.apache.org/r/63711/diff/1-2/
Testing
---
Qtest Added locally passed.
Thanks,
cheng xu
Added locally passed.
Thanks,
cheng xu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58501/#review174264
---
Ship it!
Ship It!
- cheng xu
On May 4, 2017, 6:19 p.m
s://reviews.apache.org/r/58501/#comment246902>
Why not passing in the default value here when
PARQUET_INT96_WRITE_ZONE_PROPERTY is not set?
- cheng xu
On May 3, 2017, 8:59 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an autom
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52493/#review153648
---
Ship it!
Ship It!
- cheng xu
On Oct. 22, 2016, 1:31 a.m
ws.apache.org/r/52493/#comment222841>
hint: better to call "testPromptPasswordOptionAsFirst" in consist with the
later one.
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java
(line 243)
<https://reviews.apache.org/r/52493/#comment222839&
is that possible to reuse the code in TestBufferedRows?
beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line
217)
<https://reviews.apache.org/r/52981/#comment222637>
Remove this line please.
- cheng xu
On Oct. 19, 2016, 7:55 p.m., Jianguo Tian wrote:
>
/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java
(line 268)
<https://reviews.apache.org/r/52493/#comment220594>
2 space indents
- cheng xu
On Oct. 4, 2016, 7:35 a.m., Vihang Karajgaonkar wrote:
>
>
)
<https://reviews.apache.org/r/51695/#comment218340>
Since this import is not needed.
jdbc/src/test/org/apache/hive/jdbc/TestRunInitialSQL.java (line 39)
<https://reviews.apache.org/r/51695/#comment218339>
Can we rename this class to TestJdbcDriver?
- cheng xu
On Sept.
QL.java (line 81)
<https://reviews.apache.org/r/51695/#comment217992>
Can we do this one time clean up in @AfterClass method?
- cheng xu
On Sept. 22, 2016, 2:49 p.m., Jianguo Tian wrote:
>
> ---
> This is an automatically gen
enerated files. :) I will review further
it.
- cheng xu
On Sept. 21, 2016, 3:25 p.m., Ke Jia wrote:
>
> ---
> This is an automatically generated e-mail. To r
tps://reviews.apache.org/r/51695/#comment217507>
Please add the case "#show tables; show/n tables"
jdbc/src/test/org/apache/hive/jdbc/TestInitSQL.java (line 75)
<https://reviews.apache.org/r/51695/#comment217504>
side.
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48839/#review149771
---
On Sept. 21, 2016, 1:27 p.m., cheng xu wrote:
>
> ---
/java/org/apache/hive/spark/client/TestMetricsCollection.java
5146e91
Diff: https://reviews.apache.org/r/48839/diff/
Testing
---
Thanks,
cheng xu
//reviews.apache.org/r/48839/#review149717
-------
On Sept. 21, 2016, 1:27 p.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To
37)
<https://reviews.apache.org/r/51695/#comment216136>
Please remove L37-38 which is debug used only.
jdbc/src/test/resources/init.sql (line 1)
<https://reviews.apache.org/r/51695/#comment216147>
Please use echo to create some tmp file and remove them after test case
comple
/test/resources/init.sql (line 3)
<https://reviews.apache.org/r/51695/#comment215563>
Remove this line since it's commented out.
- cheng xu
On Sept. 8, 2016, 8:52 a.m., Jianguo Tian wrote:
>
> -
---
Newly added qtest passed.
Thanks,
cheng xu
/ColumnProjectionUtils.java
0c7ac30
Diff: https://reviews.apache.org/r/48716/diff/
Testing
---
Newly added qtest passed.
Thanks,
cheng xu
-mail. To reply, visit:
https://reviews.apache.org/r/48716/#review140991
-------
On June 15, 2016, 11:34 a.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48716/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49264/#review139907
---
Ship it!
Ship It!
- cheng xu
On June 29, 2016, 1:19 a.m
s for this?
ql/src/test/queries/clientpositive/reloadJar.q (line 9)
<https://reviews.apache.org/r/49264/#comment205044>
Tailing space.
ql/src/test/queries/clientpositive/reloadJar.q (line 12)
<https://reviews.apache.org/r/49264/#comment205045>
Tailing space.
- cheng xu
/TestMetricsCollection.java
5146e91
Diff: https://reviews.apache.org/r/48839/diff/
Testing
---
Thanks,
cheng xu
/ColumnProjectionUtils.java
0c7ac30
Diff: https://reviews.apache.org/r/48716/diff/
Testing
---
Newly added qtest passed.
Thanks,
cheng xu
.
Thanks,
cheng xu
Cheng Xu created HIVE-13056:
---
Summary: oozie-hive fails to authenticate
Key: HIVE-13056
URL: https://issues.apache.org/jira/browse/HIVE-13056
Project: Hive
Issue Type: Bug
Components
> On Oct. 26, 2015, 9:14 a.m., cheng xu wrote:
> > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line
> > <https://reviews.apache.org/r/39626/diff/2/?file=1106510#file1106510line>
> >
> > Method `exeCommandWithPrefix` failed to handle the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39626/#review103978
---
Ship it!
Ship It!
- cheng xu
On Oct. 25, 2015, 7:13 a.m
s().getEntireLineAsCommand());
} else {
// handle SQLLine command in beeline which starts with ! and does
not end with ;
return execCommandWithPrefix(line);
}
```
- cheng xu
On Oct. 25, 2015, 7:13 a.m., Chaoyu Tang wrote:
>
> -
/cli/operation/SQLOperation.java
cc9df76
Diff: https://reviews.apache.org/r/38247/diff/
Testing
---
UT and smoke test passed locally
Thanks,
cheng xu
.
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38247/#review98694
---
On Sept. 10, 2015, 11:35 a.m.
cc9df76
Diff: https://reviews.apache.org/r/38247/diff/
Testing
---
UT and smoke test passed locally
Thanks,
cheng xu
080-1084 since it's not reasonable to have single line match the
multiple ReflectiveCommandHandler.
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38044/#re
rg/r/38044/diff/
Testing
---
Local smoke test passed and unit test passed locally
Thanks,
cheng xu
since there's only one match "list"
exists.
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38044/#review97494
--------
y one match "list"
exists.
- cheng xu
On Sept. 2, 2015, 3:16 p.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38044/
> --
test passed and unit test passed locally
Thanks,
cheng xu
> On July 31, 2015, 1:35 p.m., cheng xu wrote:
> > Looks good to me. Just one minor question.
Also I am wondering why this search argument works fine for ORC.
- cheng
---
This is an automatically generated e-mail. To rep
/hadoop/hive/ql/io/parquet/read/ParquetFilterPredicateConverter.java
(lines 103 - 104)
<https://reviews.apache.org/r/36942/#comment148112>
Why we need to create the leaf when columns is null?
- cheng xu
On July 31, 2015, 5:22 a.m., Sergio Pena
/beeline/BeeLineOpts.java 894f74f
beeline/src/java/org/apache/hive/beeline/Commands.java b07388a
beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java fa94c89
Diff: https://reviews.apache.org/r/36443/diff/
Testing
---
Test passed locally
Thanks,
cheng xu
/hive/beeline/Commands.java d490273
beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17
Diff: https://reviews.apache.org/r/36300/diff/
Testing
---
Partial UT passed and local cluster test passed.
Thanks,
cheng xu
reviews.apache.org/r/36300/#review90889
-------
On July 8, 2015, 4:44 p.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To re
,
cheng xu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/#review90860
---
Ship it!
Ship It!
- cheng xu
On July 8, 2015, 11:05 a.m., lun
)
<https://reviews.apache.org/r/36156/#comment144012>
Minor issue: Please remove the tailing space in the qfile. Thank you!
- cheng xu
On July 8, 2015, 10:13 a.m., lun gao wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35950/#review90838
---
Ship it!
Ship It!
- cheng xu
On July 8, 2015, 12:25 a.m
--
>
> (Updated June 28, 2015, 8:29 a.m.)
>
>
> Review request for hive, Ryan Blue, cheng xu, and Dong Chen.
>
>
> Bugs: HIVE-11131
> https://issues.apache.org/jira/browse/HIVE-11131
>
>
> Repository: hive-git
>
>
> Description
> -
rter?
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriter.java
(line 538)
<https://reviews.apache.org/r/35950/#comment142420>
DateDataWriter
- cheng xu
On June 28, 2015, 8:29 a.m., Sergio Pena wrote:
>
>
---
Unit test passed
Thanks,
cheng xu
/hadoop/hive/ql/processors/SetProcessor.java bc9254c
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
33ee16b
Diff: https://reviews.apache.org/r/35107/diff/
Testing
---
Unit test passed
Thanks,
cheng xu
being substituted for
> > shell command?
>
> cheng xu wrote:
> No, this method is only used for retrieving hive configurations. For env
> and sys variables, they are subsituted by VariableSubstitution.
>
> Xuefu Zhang wrote:
> Not sure if I understand it.
oot/workspace/test.sql
> ;
OK
Time taken: 0.192 seconds
hive> show tables;
OK
test2
Time taken: 0.117 seconds, Fetched: 1 row(s)
```
- cheng
---
This is an automatically generated e-mail. To reply, visit:
h
cc0414d
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java bc9254c
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
33ee16b
Diff: https://reviews.apache.org/r/35107/diff/
Testing
---
Unit test passed
Thanks,
cheng xu
e-mail. To reply, visit:
https://reviews.apache.org/r/35107/#review89251
-------
On June 25, 2015, 1:54 p.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35107/
>
hanks,
cheng xu
27;s not effective.
> >
> > Shell command (starting with !sh) is executed in the client (Beeline). I
> > think we are fine if variable substituion doesn't work for shell command.
> > We can address that as a followup taks if desirable.
>
> cheng xu wrote:
&
27;s not effective.
> >
> > Shell command (starting with !sh) is executed in the client (Beeline). I
> > think we are fine if variable substituion doesn't work for shell command.
> > We can address that as a followup taks if desirable.
>
> cheng xu wrote:
&
27;s not effective.
> >
> > Shell command (starting with !sh) is executed in the client (Beeline). I
> > think we are fine if variable substituion doesn't work for shell command.
> > We can address that as a followup taks if desirable.
>
> cheng xu wrote:
&
27;s not effective.
> >
> > Shell command (starting with !sh) is executed in the client (Beeline). I
> > think we are fine if variable substituion doesn't work for shell command.
> > We can address that as a followup taks if desirable.
>
> cheng xu wrote:
&
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35107/#review87090
---
On June 5, 2015, 10:09 a.m., cheng xu wrote:
>
> ---
beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java 6cbb030
Diff: https://reviews.apache.org/r/35107/diff/
Testing
---
Unit test passed
Thanks,
cheng xu
/TestHiveCli.java 6cbb030
Diff: https://reviews.apache.org/r/35107/diff/
Testing
---
Unit test passed
Thanks,
cheng xu
f537b98
common/src/java/org/apache/hive/common/util/HiveTestUtils.java db34494
ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 45ad22a
Diff: https://reviews.apache.org/r/34922/diff/
Testing
---
UT passed locally
Thanks,
cheng xu
/TestSessionState.java 45ad22a
Diff: https://reviews.apache.org/r/34922/diff/
Testing
---
UT passed locally
Thanks,
cheng xu
f537b98
common/src/java/org/apache/hive/common/util/HiveTestUtils.java db34494
ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 45ad22a
Diff: https://reviews.apache.org/r/34922/diff/
Testing
---
UT passed locally
Thanks,
cheng xu
/postgresql-9.3.jdbc3.jar f537b98
common/src/java/org/apache/hive/common/util/HiveTestUtils.java db34494
ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 45ad22a
Diff: https://reviews.apache.org/r/34922/diff/
Testing
---
UT passed locally
Thanks,
cheng xu
/BeeLine.java 4a82635
beeline/src/java/org/apache/hive/beeline/Commands.java 4c60525
beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java cc0b598
Diff: https://reviews.apache.org/r/34752/diff/
Testing
---
Newly created UT passed
Thanks,
cheng xu
/TestHiveCli.java cc0b598
Diff: https://reviews.apache.org/r/34752/diff/
Testing
---
Newly created UT passed
Thanks,
cheng xu
https://reviews.apache.org/r/34473/diff/
Testing
---
Newly added qtest and UT passed locally
Thanks,
cheng xu
://reviews.apache.org/r/34752/diff/
Testing
---
Newly created UT passed
Thanks,
cheng xu
/RefreshedJarClassV1.txt PRE-CREATION
ql/src/test/resources/RefreshedJarClassV2.txt PRE-CREATION
Diff: https://reviews.apache.org/r/34248/diff/
Testing
---
UT passed
Thanks,
cheng xu
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34473/#review84758
-------
On May 22, 2015, 6:26 a.m., cheng xu wrote:
>
> ---
eries/clientpositive/acid_parquet_insert.q PRE-CREATION
ql/src/test/results/clientpositive/acid_parquet_insert.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/34473/diff/
Testing
---
Newly added qtest and UT passed locally
Thanks,
cheng xu
parquet/serde/ObjectArrayWritableObjectInspector.java
> 571f993
>
> ql/src/test/org/apache/hadoop/hive/ql/io/parquet/acid/TestParquetRecordUpdater.java
> PRE-CREATION
> ql/src/test/queries/clientpositive/acid_parquet_insert.q PRE-CREATION
> ql/src/test/results/clientpositive/acid_parquet_insert.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34473/diff/
>
>
> Testing
> ---
>
> Newly added qtest and UT passed locally
>
>
> Thanks,
>
> cheng xu
>
>
/reviews.apache.org/r/33956/#comment136021>
drop table encryptedTable PURGE;
- cheng xu
On May 7, 2015, 9:23 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
/clientpositive/acid_parquet_insert.q PRE-CREATION
ql/src/test/results/clientpositive/acid_parquet_insert.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/34473/diff/
Testing
---
Newly added qtest and UT passed locally
Thanks,
cheng xu
create
the new constructor in ParquetStructObjectInspector. Thank yoU!
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34473/#review84574
---------
,
cheng xu
pache/hadoop/hive/serde2/avro/TestAvroDeserializer.java
<https://reviews.apache.org/r/34235/#comment134962>
remove space pls
Some minor issues and a question
- cheng xu
On May 14, 2015, 10:07 p.m., Swarnim Kulkarni wrote:
>
> --
PRE-CREATION
ql/src/test/resources/RefreshedJarClassV2.txt PRE-CREATION
Diff: https://reviews.apache.org/r/34248/diff/
Testing
---
UT passed
Thanks,
cheng xu
-CREATION
beeline/src/test/resources/hive-site.xml PRE-CREATION
Diff: https://reviews.apache.org/r/33881/diff/
Testing
---
Newly add unit test passed locally.
Thanks,
cheng xu
1 - 100 of 233 matches
Mail list logo
