> On Sept. 12, 2015, 6:46 a.m., Xuefu Zhang wrote: > > beeline/src/java/org/apache/hive/beeline/Commands.java, line 823 > > <https://reviews.apache.org/r/38247/diff/1/?file=1066968#file1066968line823> > > > > This seems weird as the method isn't new but shown as new here.
Yes, it's quite strange why it was marked as new added lines. This code snippet is borrowed from old Hive CLI. > On Sept. 12, 2015, 6:46 a.m., Xuefu Zhang wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 1090 > > <https://reviews.apache.org/r/38247/diff/1/?file=1066964#file1066964line1090> > > > > Again I have trouble understanding this: if cmdMap.size() > 1, then > > there must be at lease one match, right? Then, how cmdMap.get(line) can > > return null, as suggested in line 1088? Further, how can handle == null > > suggest multiple matches? I know this is old code, but let's clean it up if > > necessary. This code of block is very tricky. Assume there are two commands "connect" "myconnect". After going through the match block, there are two entries in the map. <<"connect", connectHander>,<"myconnect", myconnectHander>>. The code will allow user to execute the "connect" methods even through there are two matches since it's an exact match. - cheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38247/#review98694 ----------------------------------------------------------- On Sept. 10, 2015, 11:35 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38247/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 11:35 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Repository: hive-git > > > Description > ------- > > The changes we made in beeline-cli branch > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 3cd2a8b > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 3388391 > beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java > PRE-CREATION > beeline/src/java/org/apache/hive/beeline/ClientHook.java PRE-CREATION > beeline/src/java/org/apache/hive/beeline/Commands.java 3cdcfb8 > beeline/src/java/org/apache/hive/beeline/cli/CliOptionsProcessor.java > PRE-CREATION > beeline/src/java/org/apache/hive/beeline/cli/HiveCli.java PRE-CREATION > beeline/src/test/org/apache/hive/beeline/TestClientCommandHookFactory.java > PRE-CREATION > beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java PRE-CREATION > beeline/src/test/resources/hive-site.xml PRE-CREATION > bin/ext/cli.sh 914aae3 > bin/ext/util/execHiveCmd.sh 167cc40 > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java d62fd5c > common/src/java/org/apache/hadoop/hive/conf/HiveVariableSource.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/conf/VariableSubstitution.java > PRE-CREATION > common/src/test/org/apache/hadoop/hive/conf/TestVariableSubstitution.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 8b7a2e8 > ql/src/java/org/apache/hadoop/hive/ql/parse/VariableSubstitution.java > e8b1d96 > ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java > 0558c53 > ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java > 25ce168 > > ql/src/java/org/apache/hadoop/hive/ql/processors/DeleteResourceProcessor.java > 9052c82 > ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java cc0414d > ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 2414e12 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 7ed8e5f > > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java > bcc66cf > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > cc9df76 > > Diff: https://reviews.apache.org/r/38247/diff/ > > > Testing > ------- > > UT and smoke test passed locally > > > Thanks, > > cheng xu > >
