Re: Review Request 21886: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)

2014-05-27 Thread Zhuoluo Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21886/#review44095 --- Ship it! Thanks, Looks good to me! - Zhuoluo Yang On May 28

Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)

2013-06-05 Thread Zhuoluo Yang
=compute_stats_long.q ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q done. Thanks, Zhuoluo Yang

Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)

2013-06-04 Thread Zhuoluo Yang
/11172/diff/ Testing --- ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_long.q ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q done. Thanks, Zhuoluo Yang

Review Request: CTAS with literal NULL creates VOID type

2013-06-04 Thread Zhuoluo Yang
/results/clientnegative/ctas_creates_void.q.out PRE-CREATION Diff: https://reviews.apache.org/r/11622/diff/ Testing --- ant test -Dtestcase=TestNegativeCliDriver -Dqfile=ctas_creates_void.q Thanks, Zhuoluo Yang

Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)

2013-06-02 Thread Zhuoluo Yang
--- ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_long.q ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q done. Thanks, Zhuoluo Yang

Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)

2013-06-02 Thread Zhuoluo Yang
ache.org/r/11172/diff/ Testing (updated) --- ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_long.q ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q done. Thanks, Zhuoluo Yang

Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)

2013-06-02 Thread Zhuoluo Yang
1488823 Diff: https://reviews.apache.org/r/11172/diff/ Testing --- Thanks, Zhuoluo Yang

Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)

2013-05-15 Thread Zhuoluo Yang
Diffs - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 1482697 Diff: https://reviews.apache.org/r/11172/diff/ Testing --- Thanks, Zhuoluo Yang

Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)

2013-05-15 Thread Zhuoluo Yang
://reviews.apache.org/r/11172/diff/ Testing --- Thanks, Zhuoluo Yang

Re: Review Request: Add 'show version' command to Hive CLI

2013-01-17 Thread Zhuoluo Yang
hod. And this kind of close are involved by HIVE-1884 to avoid potential risk of resource leaks in Hive, I think... - Zhuoluo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8958/#review15438

Re: Review Request: Add 'show version' command to Hive CLI

2013-01-17 Thread Zhuoluo Yang
12:26:12 CST 2013 git://github.com/apache/hive.git on branch trunk Time taken: 0.522 seconds, Fetched: 2 row(s) hive> Thanks, Zhuoluo Yang

Re: Review Request: Add 'show version' command to Hive CLI

2013-01-15 Thread Zhuoluo Yang
CST 2013 git://github.com/apache/hive.git on branch trunk Time taken: 0.522 seconds, Fetched: 2 row(s) hive> Thanks, Zhuoluo Yang

Re: Review Request: Add 'show version' command to Hive CLI

2013-01-15 Thread Zhuoluo Yang
f/hive/trunk Time taken: 0.279 seconds, Fetched: 2 row(s) hive> Thanks, Zhuoluo Yang

Review Request: Add 'show version' command to Hive CLI

2013-01-15 Thread Zhuoluo Yang
SNAPSHOT from 1432865 by zhuoluo on Tue Jan 15 20:58:42 CST 2013 http://svn.apache.org/repos/asf/hive/trunk Time taken: 0.279 seconds, Fetched: 2 row(s) hive> Thanks, Zhuoluo Yang

Re: Review Request: HIVE-305: Port Hadoop streaming's counters/status reporters to Hive Transforms

2013-01-12 Thread Zhuoluo Yang
sting --- Thanks, Zhuoluo Yang

Review Request: HIVE-305: Port Hadoop streaming's counters/status reporters to Hive Transforms

2013-01-12 Thread Zhuoluo Yang
a/org/apache/hadoop/hive/conf/HiveConf.java 1431196 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 1431196 Diff: https://reviews.apache.org/r/8936/diff/ Testing --- Thanks, Zhuoluo Yang

Re: Review Request: HIVE-2227 Remove ProgressCounter enum in Operator

2011-06-16 Thread Zhuoluo Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/931/ --- (Updated 2011-06-17 02:49:48.793536) Review request for hive and Yongqiang He.

Review Request: HIVE-2227 Remove ProgressCounter enum in Operator

2011-06-16 Thread Zhuoluo Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/931/ --- Review request for hive and Yongqiang He. Summary --- After HIVE-1701, it is