-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11172/
-----------------------------------------------------------

(Updated June 4, 2013, 1:41 p.m.)


Review request for hive, Carl Steinbach, Carl Steinbach, Ashutosh Chauhan, 
Shreepadma Venugopalan, and fangkun cao.


Changes
-------

Sorry for my ignorance of the empty table.
I think a UT fix is a quite simple way, shall we make the min/max value zero if 
the table is empty?


Description
-------

An initialization error.
Make double and long initialize correctly.
Would you review that and assign the issue to me?


This addresses bug HIVE-4561.
    https://issues.apache.org/jira/browse/HIVE-4561


Diffs (updated)
-----

  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
 1489292 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_empty_table.q.out
 1489292 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_long.q.out
 1489292 

Diff: https://reviews.apache.org/r/11172/diff/


Testing
-------

ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_long.q
ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q

done.


Thanks,

Zhuoluo Yang

Reply via email to