Re: Review Request 24085: HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24085/#review50049 --- Ship it! Ship It! - Tom White On Aug. 8, 2014, midnight, Ashish

Re: Review Request 24085: HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24085/#review49224 --- Ship it! Ship It! - Tom White On July 30, 2014, 2:33 a.m

Re: Review Request 23387: HIVE-6806: Native avro support

> On July 18, 2014, 1:57 p.m., Tom White wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java, line 112 > > <https://reviews.apache.org/r/23387/diff/9/?file=634614#file634614line112> > > > > Is it possible to default name to table name

Re: Review Request 23387: HIVE-6806: Native avro support

> On July 18, 2014, 1:57 p.m., Tom White wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java, line 112 > > <https://reviews.apache.org/r/23387/diff/9/?file=634614#file634614line112> > > > > Is it possible to default name to table name

Re: Review Request 23387: HIVE-6806: Native avro support

> On July 18, 2014, 1:57 p.m., Tom White wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java, line 112 > > <https://reviews.apache.org/r/23387/diff/9/?file=634614#file634614line112> > > > > Is it possible to default name to table name

Re: Review Request 23387: HIVE-6806: Native avro support

> On July 17, 2014, 1:49 p.m., Tom White wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java, > > line 229 > > <https://reviews.apache.org/r/23387/diff/8/?file=634160#file634160line229> > > > > It would be simpler to make

Re: Review Request 23387: HIVE-6806: Native avro support

che.org/r/23387/#comment84413> This should add to the start of the list. Also, needs a test for this case. - Tom White On July 17, 2014, 9:10 p.m., Ashish Singh wrote: > > --- > This is an automatically g

Re: Review Request 23387: HIVE-6806: Native avro support

ache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java <https://reviews.apache.org/r/23387/#comment84254> Also need to test the case when the union includes NULL, to check it's not included twice. Also, when it's included but not in the first branch of the union. - Tom White On

Re: Review Request 23387: HIVE-6806: Native avro support

84127> Add a field for each Hive type to test they can all work in the context of a record. Also add a nested record. - Tom White On July 16, 2014, 3:35 a.m., Ashish Singh wrote: > > --- > This is an automatically gene

[jira] [Updated] (HIVE-2468) Make Hive compile against Hadoop 0.23

[ https://issues.apache.org/jira/browse/HIVE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2468: Status: Patch Available (was: Open) > Make Hive compile against Hadoop 0

[jira] [Updated] (HIVE-2468) Make Hive compile against Hadoop 0.23

[ https://issues.apache.org/jira/browse/HIVE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2468: Attachment: HIVE-2468.patch New patch with Amareshwari's change to bin/hive. > M

Re: Review Request: HIVE-2468 - Make Hive compile against Hadoop 0.22

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2762/ --- (Updated 2011-11-30 16:57:27.344021) Review request for hive. Summary ---

[jira] [Updated] (HIVE-2468) Make Hive compile against Hadoop 0.23

[ https://issues.apache.org/jira/browse/HIVE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2468: Attachment: HIVE-2468.patch This patch fixes org.apache.hadoop.hive.ql.io.TestSymlinkTextInputFormat (the

[jira] [Updated] (HIVE-2468) Make Hive compile against Hadoop 0.23

[ https://issues.apache.org/jira/browse/HIVE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2468: Attachment: HIVE-2468.patch Here's a work in progress patch which passes some of the tests now. *

[jira] [Updated] (HIVE-2468) Make Hive compile against Hadoop 0.23

[ https://issues.apache.org/jira/browse/HIVE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2468: Attachment: HIVE-2468.patch It's not complete yet, but here's an updated patch. I still need t

[jira] [Commented] (HIVE-2468) Make Hive compile against Hadoop 0.23

[ https://issues.apache.org/jira/browse/HIVE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155593#comment-13155593 ] Tom White commented on HIVE-2468: - Thanks for the report, Amareshwari. I cleared my

[jira] [Commented] (HIVE-2468) Make Hive compile against Hadoop 0.23

[ https://issues.apache.org/jira/browse/HIVE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153401#comment-13153401 ] Tom White commented on HIVE-2468: - All tests pass against 0.20. &g

Re: Review Request: HIVE-2468 - Make Hive compile against Hadoop 0.22

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2762/ --- (Updated 2011-11-18 22:06:29.024823) Review request for hive. Changes ---

Re: Review Request: HIVE-2468 - Make Hive compile against Hadoop 0.22

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2762/#review3316 --- On 2011-11-07 23:55:47, Tom White wrote: > > -

Review Request: HIVE-2468 - Make Hive compile against Hadoop 0.22

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2762/ --- Review request for hive. Summary --- See https://issues.apache.org/jira/bro

[jira] [Updated] (HIVE-2468) Make Hive compile against Hadoop 0.22

[ https://issues.apache.org/jira/browse/HIVE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2468: Attachment: HIVE-2468.patch Here's a patch that Roman Shaposhnik and I wrote to get Hive compiling ag

Re: Review Request: HIVE-2457. Files in Avro-backed Hive tables do not have a ".avro" extension

> On 2011-09-21 00:26:28, Carl Steinbach wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 892 > > <https://reviews.apache.org/r/1989/diff/1/?file=2#file2line892> > > > > Please add this configuration property to HiveC

[jira] [Updated] (HIVE-2457) Files in Avro-backed Hive tables do not have a ".avro" extension

[ https://issues.apache.org/jira/browse/HIVE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2457: Attachment: HIVE-2457.patch Here's a new patch which addresses all of Carl's feedback. (I don&#x

[jira] [Updated] (HIVE-2457) Files in Avro-backed Hive tables do not have a ".avro" extension

[ https://issues.apache.org/jira/browse/HIVE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2457: Status: Patch Available (was: Open) > Files in Avro-backed Hive tables do not have a ".avro&qu

Re: Review Request: HIVE-2457. Files in Avro-backed Hive tables do not have a ".avro" extension

> On 2011-09-21 00:26:28, Carl Steinbach wrote: > > Thanks for the review! > On 2011-09-21 00:26:28, Carl Steinbach wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 892 > > > > > > Pleas

[jira] [Updated] (HIVE-2457) Files in Avro-backed Hive tables do not have a ".avro" extension

[ https://issues.apache.org/jira/browse/HIVE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2457: Status: Patch Available (was: Open) > Files in Avro-backed Hive tables do not have a ".avro&qu

[jira] [Updated] (HIVE-2457) Files in Avro-backed Hive tables do not have a ".avro" extension

[ https://issues.apache.org/jira/browse/HIVE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HIVE-2457: Attachment: HIVE-2457.patch Here's a patch which introduces a new property, {{hive.output.file.exte

[jira] [Created] (HIVE-2457) Files in Avro-backed Hive tables do not have a ".avro" extension

mprovement Components: Query Processor, Serializers/Deserializers Reporter: Tom White When using the Avro SerDe (see HIVE-895, https://github.com/jghoman/haivvreo) the files created for an Avro table do not have a ".avro" extension, which causes problems for tools li