----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2762/ -----------------------------------------------------------
(Updated 2011-11-18 22:06:29.024823) Review request for hive. Changes ------- Thanks for all the feedback! Here's a new patch which addresses it. * Change build.properties to the 0.20-based version numbers (build against 23 with "ant -Dhadoop.version=0.23.0 -Dhadoop.security.version=0.23.0 -Dhadoop.security.version.prefix=0.23") * Makes the change to bin/hive that Amareshwari suggested. * Removed duplicate classes names from the 0.23 shim as Thomas suggested. I also removed some classes that I needlessly introduced into the 23 shim tree in the last patch. Amareshwari, can you post your changes to CombineFileInputFormatShim so we can include those too? I also need to run unit tests against 0.20 to check there are no regressions. Summary ------- See https://issues.apache.org/jira/browse/HIVE-2468 This addresses bug HIVE-2468. https://issues.apache.org/jira/browse/HIVE-2468 Diffs (updated) ----- trunk/shims/src/0.23/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java PRE-CREATION trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1203794 trunk/shims/build.xml 1203794 trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1203794 trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java 1203794 trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java 1203794 trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableOutputFormat.java 1203794 trunk/build.properties 1203794 trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java 1203794 trunk/shims/src/0.23/java/org/apache/hadoop/hive/shims/Jetty23Shims.java PRE-CREATION trunk/shims/src/0.23/java/org/apache/hadoop/hive/thrift/DelegationTokenIdentifier23.java PRE-CREATION trunk/shims/src/0.23/java/org/apache/hadoop/hive/thrift/DelegationTokenSelector23.java PRE-CREATION trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java 1203794 trunk/shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java 1203794 Diff: https://reviews.apache.org/r/2762/diff Testing ------- Thanks, Tom
