Re: Review Request 69462: HIVE-20936

2018-12-21 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/#review211519 --- Ship it! Ship It! - Eugene Koifman On Dec. 21, 2018, 4:30 p.

Re: Review Request 69462: HIVE-20936

2018-12-21 Thread Jaume Marhuenda
> On Dec. 21, 2018, 8:57 p.m., Eugene Koifman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionInfo.java > > Line 34 (original), 42 (patched) > > > > > >

Re: Review Request 69462: HIVE-20936

2018-12-21 Thread Jaume Marhuenda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/ --- (Updated Dec. 22, 2018, 12:30 a.m.) Review request for hive. Repository: hive

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 662 (patched) > > > > > > The second

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Dec. 22, 2018, 12:27 a.m.) Review request for hive, Adam Holley, Morio

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 4621 (patched) > > > > > > This is the s

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
> On Dec. 20, 2018, 2:46 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 1405 (patched) > > > > > > I thought we were go

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 662 (patched) > > > > > > The second

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 816 (patched) > > > > > > Nit: This

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 4621 (patched) > > > > > > This is the s

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Dec. 21, 2018, 9:36 p.m.) Review request for hive, Adam Holley, Morio

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Karthik Manamcheri via Review Board
> On Dec. 20, 2018, 2:46 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 220-221 (patched) > > > > > > These two var

Re: Review Request 69462: HIVE-20936

2018-12-21 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/#review211508 --- it looks like it has merge conflits standalone-metastore/metasto

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Morio Ramdenbourg via Review Board
> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 2458 (patched) > > > > > > This is

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69562/ --- (Updated Dec. 21, 2018, 8:30 p.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Jesús Camacho Rodríguez
> On Dec. 21, 2018, 5:12 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java > > Lines 110 (patched) > > > > > > It will be good to add a comment here stati

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
> On Dec. 20, 2018, 2:46 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 2934 (patched) > > > > > > What is this extra s

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69562/#review211502 --- ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGather

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Na Li via Review Board
> On Dec. 20, 2018, 2:46 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 220-221 (patched) > > > > > > These two var

[jira] [Created] (HIVE-21064) java.lang.ClassCastException: org.apache.hadoop.hive.serde2.lazy.LazyStruct cannot be cast to org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch

2018-12-21 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created HIVE-21064: -- Summary: java.lang.ClassCastException: org.apache.hadoop.hive.serde2.lazy.LazyStruct cannot be cast to org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch Key: HIVE-21064

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Jesús Camacho Rodríguez
> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q > > Line 7 (original), 7 (patched) > > > > > > Is it necessary to specify schema to get auto-