> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 662 (patched) > > <https://reviews.apache.org/r/69585/diff/2/?file=2114851#file2114851line662> > > > > The second parameter in ConfVars corresponds to the Hive property name. > > > > E.g. metastore.client.filter.result -> > > hive.metastore.client.filter.result > > > > So this should be: > > METASTORE_CLIENT_FILTER_RESULT("metastore.client.filter.result", > > "hive.metastore.client.filter.result" ...) > > Na Li wrote: > this is new field, and does not exist in hive configuration. Since we are > splitting HMS from Hive, does it make sense to add this new one in hive > configuration? > > Morio Ramdenbourg wrote: > Hmm, I'm not exactly sure - HMS is still part of the Hive code base. > > Others who have been adding new properties to only HMS have been putting > Hive name, so I think it's safe. Someone should confirm this though. > > Na Li wrote: > I see both examples in MetastoreConf.java. I will talk with others to > find out the rule. > > 1) hiveName is "hive." + varname > ADDED_JARS("metastore.added.jars.path", "hive.added.jars.path", "", > "This an internal parameter."), > > > 2) hiveName is the same as varname > CATALOG_DEFAULT("metastore.catalog.default", > "metastore.catalog.default", "hive", > "The default catalog to use when a catalog is not specified. > Default is 'hive' (the " + > "default catalog)."),
I changed the hiveName to start with "hive." - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review211446 ----------------------------------------------------------- On Dec. 22, 2018, 12:27 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69585/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2018, 12:27 a.m.) > > > Review request for hive, Adam Holley, Morio Ramdenbourg, Peter Vary, Sergio > Pena, and Vihang Karajgaonkar. > > > Bugs: HIVE-20776 > https://issues.apache.org/jira/browse/HIVE-20776 > > > Repository: hive-git > > > Description > ------- > > add filtering to read result at HMS server, so user cannot see metadata > he/she has no privileges. Filtering is enabled/disabled based on > configuration. > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 9eb1193a27120b5167f92daf67bf6a1c4e1d9927 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > fb0b2fe6fb9fd4b4c92a6a39f06f39a4641aaabd > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java > PRE-CREATION > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 0a1b96dcf62d3536cab2ce074d27a6225b2d3443 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java > 7dc69bc4e92875c8962dcd313b16f0f90ea8b057 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetastoreFilterHook.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69585/diff/5/ > > > Testing > ------- > > Existing unit tests passed. > add new unit tests for filtering at HMS server and HMS client > add code to enabled/disable filtering at HMS client based on configuration > > > Thanks, > > Na Li > >
