Re: Review Request 65778: HIVE-18726 Implement DEFAULT constraint

2018-03-02 Thread Vineet Garg
> On Feb. 27, 2018, 2:07 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultConstraint.java > > Lines 34 (patched) > > > > > > Is there a reason to implement Serializable ? > > Vi

Re: Review Request 65778: HIVE-18726 Implement DEFAULT constraint

2018-03-02 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65778/ --- (Updated March 3, 2018, 1:01 a.m.) Review request for hive, Ashutosh Chauhan an

[jira] [Created] (HIVE-18855) Fix unit test TestMiniLlapLocalCliDriver.testCliDriver[results_cache_1]

2018-03-02 Thread Jason Dere (JIRA)
Jason Dere created HIVE-18855: - Summary: Fix unit test TestMiniLlapLocalCliDriver.testCliDriver[results_cache_1] Key: HIVE-18855 URL: https://issues.apache.org/jira/browse/HIVE-18855 Project: Hive

[jira] [Created] (HIVE-18854) Add metastore event handler for DEFAULT constraint

2018-03-02 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-18854: -- Summary: Add metastore event handler for DEFAULT constraint Key: HIVE-18854 URL: https://issues.apache.org/jira/browse/HIVE-18854 Project: Hive Issue Type: Task

Re: Review Request 65422: HIVE-17626

2018-03-02 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/#review198543 --- data/conf/hive-site.xml Lines 338 (patched)

[jira] [Created] (HIVE-18853) Alter table change column shouldn't let define same constraint on a column with existing constraint

2018-03-02 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-18853: -- Summary: Alter table change column shouldn't let define same constraint on a column with existing constraint Key: HIVE-18853 URL: https://issues.apache.org/jira/browse/HIVE-18853

Re: Review Request 65745: HIVE-18743: CREATE TABLE on S3 data can be extremely slow. DO_NOT_UPDATE_STATS workaround is buggy.

2018-03-02 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65745/#review198560 --- standalone-metastore/src/main/java/org/apache/hadoop/hive/metasto

[jira] [Created] (HIVE-18852) Misleading error message in alter table validation

2018-03-02 Thread Dan Burkert (JIRA)
Dan Burkert created HIVE-18852: -- Summary: Misleading error message in alter table validation Key: HIVE-18852 URL: https://issues.apache.org/jira/browse/HIVE-18852 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18851) make Hive basic stats valid for ACID; cleanup and refactor the code

2018-03-02 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18851: --- Summary: make Hive basic stats valid for ACID; cleanup and refactor the code Key: HIVE-18851 URL: https://issues.apache.org/jira/browse/HIVE-18851 Project: Hive

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-03-02 Thread Sergey Shelukhin
> On March 1, 2018, 12:40 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Lines 1683 (patched) > > > > > > For full acid table, if you have no ParseDelta.isDeleteDelta(),

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-03-02 Thread Sergey Shelukhin
> On Feb. 2, 2018, 10 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 1947 (patched) > > > > > > I think this should be in somewhere in the BasicStat related clas

Re: information_schema in metastore

2018-03-02 Thread Thejas Nair
INFORMATION_SCHEMA is part of the SQL92 standard. This is a feature supported and widely used in most mature RDBMs. The idea is to enable that for Hive as well. https://issues.apache.org/jira/browse/HIVE-1010 On Fri, Mar 2, 2018 at 10:59 AM, Vihang Karajgaonkar wrote: > I recently noticed the wo

Re: HMS API testing and direct SQL

2018-03-02 Thread Sergey Shelukhin
There used to be a special ObjectStore for tests that would run stuff both with and without DirectSql in tests and fail on mismatch. Not sure about its state now. On 18/3/2, 11:05, "Vihang Karajgaonkar" wrote: >Direct SQL is controlled by configs metastore.try.direct.sql >and metastore.try.direc

[GitHub] hive pull request #314: HIVE-18750: Exchange partition should be disabled on...

2018-03-02 Thread sankarh
Github user sankarh closed the pull request at: https://github.com/apache/hive/pull/314 ---

Re: HMS API testing and direct SQL

2018-03-02 Thread Vihang Karajgaonkar
Direct SQL is controlled by configs metastore.try.direct.sql and metastore.try.direct.sql.ddl which are enabled by default. So I am guessing the API tests will cover the direct SQL enabled path only unless the tests override the default configs (I don't think they do). On Fri, Mar 2, 2018 at 10:51

information_schema in metastore

2018-03-02 Thread Vihang Karajgaonkar
I recently noticed the work done in HIVE-16946 related to information schema. Based on what I understand so far, it uses JdbcSerDe to create hive tables similar to metastore db tables. It looks like an interesting idea. Can someone share how is it

HMS API testing and direct SQL

2018-03-02 Thread Alexander Kolbasov
We currently use two distinct code paths via ObjectStore - the regular one and direct SQL. So I think all the tests that verify HMS API functionality should somehow cover both cases. Peter - what are your thoughts? - Alex

Re: Review Request 65745: HIVE-18743: CREATE TABLE on S3 data can be extremely slow. DO_NOT_UPDATE_STATS workaround is buggy.

2018-03-02 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65745/#review198520 --- standalone-metastore/src/main/java/org/apache/hadoop/hive/metasto

[jira] [Created] (HIVE-18850) Add a timeout for query parser

2018-03-02 Thread Amruth S (JIRA)
Amruth S created HIVE-18850: --- Summary: Add a timeout for query parser Key: HIVE-18850 URL: https://issues.apache.org/jira/browse/HIVE-18850 Project: Hive Issue Type: Improvement Component