> On Feb. 2, 2018, 10 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 1947 (patched) > > <https://reviews.apache.org/r/65415/diff/2/?file=1950619#file1950619line1953> > > > > I think this should be in somewhere in the BasicStat related class; or > > this can't be moved there?
It's used in metastore, so it cannot be moved to ql currently > On Feb. 2, 2018, 10 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java > > Line 127 (original), 127 (patched) > > <https://reviews.apache.org/r/65415/diff/2/?file=1950625#file1950625line127> > > > > It seems to me that the old conditionals have done almost the same...by > > changing p.isAcid to p.isTransactional ; I don't see any difference; since > > if its being rewritten the flag will be turned on Transactional is broader than full ACID (it means ACID or MM), and the name is more explicit. Most of these methods were changed and/or renamed in a prior patch to make the clearer. > On Feb. 2, 2018, 10 a.m., Zoltan Haindrich wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 674 (patched) > > <https://reviews.apache.org/r/65415/diff/2/?file=1950630#file1950630line684> > > > > I don't understand why Updated the comment - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/#review196696 ----------------------------------------------------------- On Feb. 27, 2018, 3:14 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65415/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2018, 3:14 a.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > f.,v fbghdscd > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/HiveStatsUtils.java > df77a4a2f2 > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java b490325091 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java fd8423129f > > ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java > 0a82225d4a > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 70fcd2c142 > ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java > 1a63d3f971 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 8b0af3e5c8 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 67d05e65dd > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 7d2de75315 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > cd6f1ee692 > ql/src/java/org/apache/hadoop/hive/ql/plan/BasicStatsWork.java a4e770ce95 > > ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java > 8ce0cb05b6 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java > 946c300750 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 1d7660e8b2 > ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java > 7591c0681b > ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 05b0474e90 > ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java > d84cf136d5 > ql/src/test/results/clientpositive/autoColumnStats_4.q.out 9c0e020351 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java > 59190893e6 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 89354a2d34 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c6e34a8a22 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java > 20c10607bb > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > b44ff8ce47 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 50f873a013 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 2599ab103e > > > Diff: https://reviews.apache.org/r/65415/diff/4/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
