Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/#review197073 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 2

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review197072 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Feb. 8, 2018,

[jira] [Created] (HIVE-18654) Add Hiveserver2 specific HADOOP_OPTS environment variable

Vihang Karajgaonkar created HIVE-18654: -- Summary: Add Hiveserver2 specific HADOOP_OPTS environment variable Key: HIVE-18654 URL: https://issues.apache.org/jira/browse/HIVE-18654 Project: Hive

Re: [DISCUSS] 26 Unit tests failing regularly

TestOperators failure is covered in HIVE-18653 Thanks Prasanth On Feb 7, 2018, at 9:01 AM, Vihang Karajgaonkar mailto:vih...@cloudera.com>> wrote: Thanks Eugene, Deepak and Sahil. I will take a look at the TestSSL ones. On Tue, Feb 6, 2018 at

[jira] [Created] (HIVE-18653) Fix TestOperators test failure in master

Prasanth Jayachandran created HIVE-18653: Summary: Fix TestOperators test failure in master Key: HIVE-18653 URL: https://issues.apache.org/jira/browse/HIVE-18653 Project: Hive Issue T

[jira] [Created] (HIVE-18652) Print Spark metrics on console

Sahil Takiar created HIVE-18652: --- Summary: Print Spark metrics on console Key: HIVE-18652 URL: https://issues.apache.org/jira/browse/HIVE-18652 Project: Hive Issue Type: Sub-task Comp

[jira] [Created] (HIVE-18651) Expose additional Spark metrics

Sahil Takiar created HIVE-18651: --- Summary: Expose additional Spark metrics Key: HIVE-18651 URL: https://issues.apache.org/jira/browse/HIVE-18651 Project: Hive Issue Type: Sub-task Com

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Feb. 7, 2018, 9 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 3891 (patched) > > > > > > I am not sure what we do with duplicates, there

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Feb. 8, 2018, 12:44 a.m.) Review request for hive and Jesús Camacho Ro

[jira] [Created] (HIVE-18650) Add compression related tests for blobstores

Yuzhou Sun created HIVE-18650: - Summary: Add compression related tests for blobstores Key: HIVE-18650 URL: https://issues.apache.org/jira/browse/HIVE-18650 Project: Hive Issue Type: Test

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- (Updated Feb. 7, 2018, 10:34 p.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same compBuilder.setIsAci

[jira] [Created] (HIVE-18649) HiveInputFormat job conf object lifecycle is unclear or broken

Sergey Shelukhin created HIVE-18649: --- Summary: HiveInputFormat job conf object lifecycle is unclear or broken Key: HIVE-18649 URL: https://issues.apache.org/jira/browse/HIVE-18649 Project: Hive

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Feb. 7, 2018, 8:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 3891 (patched) > > > > > > The check should be on _groupByExpr.size()_?

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Feb. 7, 2018, 8:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 3891 (patched) > > > > > > The check should be on _groupByExpr.size()_?

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review197037 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Feb. 7, 2018, 8:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 3891 (patched) > > > > > > The check should be on _groupByExpr.size()_?

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review197026 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Feb. 7, 2018, 8:21 p.m.) Review request for hive and Jesús Camacho Rod

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

> On Feb. 6, 2018, 12:33 a.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/thrift/hive_metastore.thrift > > Lines 332 (patched) > > > > > > 1. Seems like you want to use this to allow/disallow load sta

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

> On Feb. 2, 2018, 5:26 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > This seems to change the logic. isAcidTab

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

> On Feb. 5, 2018, 10:52 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java > > Line 862 (original), 863 (patched) > > > > > > is 'job' cloned somewhere between invocations?

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/#review196904 --- ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java L

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review197017 --- Could we add an error message at compilation time for grouping set

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Feb. 7, 2018, 7:15 p.m.) Review request for hive and Jesús Camacho Rod

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 7, 2018, 6:04 p.m.) Review request for hive, Ashutosh Chauhan, Eu

[jira] [Created] (HIVE-18648) Investigate SMB related test failures in llap_smb and auto_sortmerge_join_2

Deepak Jaiswal created HIVE-18648: - Summary: Investigate SMB related test failures in llap_smb and auto_sortmerge_join_2 Key: HIVE-18648 URL: https://issues.apache.org/jira/browse/HIVE-18648 Project:

Re: [DISCUSS] 26 Unit tests failing regularly

Thanks Eugene, Deepak and Sahil. I will take a look at the TestSSL ones. On Tue, Feb 6, 2018 at 10:54 AM, Sahil Takiar wrote: > I can take a look at the Spark and Encryption ones. > > On Tue, Feb 6, 2018 at 10:38 AM, Deepak Jaiswal > wrote: > > > I already have JIRA for > > org.apache.hadoop.hi

Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/ --- (Updated Feb. 7, 2018, 3:35 p.m.) Review request for hive, Peter Vary and Adam

Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

> On Feb. 7, 2018, 10:16 a.m., Adam Szita wrote: > > Thanks for the patch Marta, this is incredibly thourough! Thanks a lot Adam for the review. - Marta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa

Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

> On Feb. 7, 2018, 11:25 a.m., Peter Vary wrote: > > Ship It! Thanks a lot Peter for the review. - Marta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/#review196982 --

[jira] [Created] (HIVE-18647) Cannot create table: Unknown column 'CREATION_METADATA_MV_CREATION_METADATA_ID_OID'

Rui Li created HIVE-18647: - Summary: Cannot create table: Unknown column 'CREATION_METADATA_MV_CREATION_METADATA_ID_OID' Key: HIVE-18647 URL: https://issues.apache.org/jira/browse/HIVE-18647 Project: Hive

[jira] [Created] (HIVE-18646) Update errata.txt for HIVE-18617

Daniel Voros created HIVE-18646: --- Summary: Update errata.txt for HIVE-18617 Key: HIVE-18646 URL: https://issues.apache.org/jira/browse/HIVE-18646 Project: Hive Issue Type: Bug Affects Versi

Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/#review196982 --- Ship it! Ship It! - Peter Vary On Feb. 5, 2018, 6:01 p.m., M

Re: Review Request 65544: HIVE-18637: WorkloadManagent Event Summary leaving subscribedCounters and currentCounters fields empty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65544/ --- (Updated Feb. 7, 2018, 10:42 a.m.) Review request for hive and Sergey Shelukhin

Re: Review Request 65331: HIVE-17751 Separate HMS Client and HMS server into separate sub-modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65331/#review196978 --- Thanks for the proposal Sasha! I agree, that we should separate cl

Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/#review196979 --- Fix it, then Ship it! Thanks for the patch Marta, this is incre

Review Request 65544: HIVE-18637: WorkloadManagent Event Summary leaving subscribedCounters and currentCounters fields empty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65544/ --- Review request for hive and Sergey Shelukhin. Bugs: HIVE-18637 https://issu

Review Request 65543: HIVE-18238

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65543/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-18238 https://issu

[jira] [Created] (HIVE-18645) invalid url address in README.txt from module hbase-handler

Saijin Huang created HIVE-18645: --- Summary: invalid url address in README.txt from module hbase-handler Key: HIVE-18645 URL: https://issues.apache.org/jira/browse/HIVE-18645 Project: Hive Issue