> On Feb. 5, 2018, 10:52 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java > > Line 862 (original), 863 (patched) > > <https://reviews.apache.org/r/65413/diff/2/?file=1950137#file1950137line863> > > > > is 'job' cloned somewhere between invocations? If not this seems like > > a bug > > Sergey Shelukhin wrote: > This is existing code. Another strange thing here is that there's job > (the field) and jobConf (the parameter), and some code in this methods > updates one while some updates the other. > They are not obviously identical. > Does it make sense to investigate/fix in a follow-up jira?
bug-for-bug compatibility... sure follow up is fine > On Feb. 5, 2018, 10:52 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507> > > > > stupid RB won't let me edit my own comment... > > Previsouly this check was testing for full acid but now just for > > transactional. Why? > > Sergey Shelukhin wrote: > It's used to skip global limit optimization. As far as I understand this > should also be skipped for insert-only tables why is that? For full acid, you have to apply delete events but for MM once you filter the set of files based on getAcidState() it should be just like non-transactional read... - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/#review196819 ----------------------------------------------------------- On Feb. 5, 2018, 7:29 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65413/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2018, 7:29 p.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > . > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99e8457c7b > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java > 5ee8aadfa7 > > hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java > 8943423244 > > hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java > 5e12614cfe > > hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java > c98d22be2e > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java > 1305902351 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > d252279be9 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 68bb168bd2 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d3aa571913 > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d > ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java > 270b576199 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java > abd42ec651 > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030 > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java > da200049bc > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java > 7b157e6486 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 07999e2e9e > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java > 0fdff7d853 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > 69447d9d34 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 190771ea6b > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 3eb869d3f6 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > b67a03f213 > ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java > e1cea22005 > ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b > ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 0e456df19c > ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java > 92f005d1dc > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java > c6a866a164 > > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java > 65508f4ddd > > > Diff: https://reviews.apache.org/r/65413/diff/3/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
