Re: Review Request 64326: HIVE-18208

2017-12-07 Thread Deepak Jaiswal
> On Dec. 8, 2017, 12:59 a.m., Jason Dere wrote: > > ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q > > Lines 29 (patched) > > > > > > Please add comment stating that the point of this setting is to disabl

[jira] [Created] (HIVE-18252) Limit the size of the object inspector caches

2017-12-07 Thread Jason Dere (JIRA)
Jason Dere created HIVE-18252: - Summary: Limit the size of the object inspector caches Key: HIVE-18252 URL: https://issues.apache.org/jira/browse/HIVE-18252 Project: Hive Issue Type: Bug

Re: checkstyle changes

2017-12-07 Thread Rui Li
I also believe 140 is a little too long. BTW do we use 2 or 4 chars for continuation indent? I personally prefer 4, but I do find both cases in out code. On Fri, Dec 8, 2017 at 6:20 AM, Alexander Kolbasov wrote: > Problem with 140-wide code isn't just laptops - in many cases we need to do > sid

[jira] [Created] (HIVE-18251) Loosen restriction for some checks

2017-12-07 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-18251: --- Summary: Loosen restriction for some checks Key: HIVE-18251 URL: https://issues.apache.org/jira/browse/HIVE-18251 Project: Hive Issue Type: Improvement

Re: Review Request 64326: HIVE-18208

2017-12-07 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64326/#review192957 --- ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q Lines

Review Request 64433: HIVE-18203 change the way WM is enabled and allow dropping the last resource plan

2017-12-07 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64433/ --- Review request for hive, Harish Jaiprakash and Prasanth_J. Repository: hive-git

Re: Review Request 62228: HIVE-17495: CachedStore: prewarm improvements, refactoring and caching some aggregate stats

2017-12-07 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62228/ --- (Updated Dec. 8, 2017, 12:06 a.m.) Review request for hive, Ashutosh Chauhan, D

[jira] [Created] (HIVE-18249) Remove Thrift dependency on fb303

2017-12-07 Thread Alexander Kolbasov (JIRA)
Alexander Kolbasov created HIVE-18249: - Summary: Remove Thrift dependency on fb303 Key: HIVE-18249 URL: https://issues.apache.org/jira/browse/HIVE-18249 Project: Hive Issue Type: Bug

Re: Review Request 64402: HIVE-18240 support getClientInfo/setClientInfo in JDBC

2017-12-07 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64402/#review193193 --- Ship it! Ship It! - Vaibhav Gumashta On Dec. 7, 2017, 3:24 a

[jira] [Created] (HIVE-18250) CBO gets turned off with duplicates in RR error

2017-12-07 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-18250: --- Summary: CBO gets turned off with duplicates in RR error Key: HIVE-18250 URL: https://issues.apache.org/jira/browse/HIVE-18250 Project: Hive Issue Type

Re: [DISCUSS] Do-it-yourself docs

2017-12-07 Thread Lefty Leverenz
We have three goals with just a few tools of persuasion. Goals: 1. Identify JIRA issues that need documentation. 2. Add doc notes or release notes to JIRA issues. 3. Document Hive code and procedures in the wiki. *(main goal)* I've been helping with #1 and #2, adding ~17 TODOC labels &

[jira] [Created] (HIVE-18248) Clean up parameters

2017-12-07 Thread Janaki Lahorani (JIRA)
Janaki Lahorani created HIVE-18248: -- Summary: Clean up parameters Key: HIVE-18248 URL: https://issues.apache.org/jira/browse/HIVE-18248 Project: Hive Issue Type: Bug Reporter: Ja

[jira] [Created] (HIVE-18247) Use DB auto-increment for indexes

2017-12-07 Thread Alexander Kolbasov (JIRA)
Alexander Kolbasov created HIVE-18247: - Summary: Use DB auto-increment for indexes Key: HIVE-18247 URL: https://issues.apache.org/jira/browse/HIVE-18247 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18246) Replace toString with getExprString in AbstractOperatorDesc::getColumnExprMapForExplain

2017-12-07 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-18246: -- Summary: Replace toString with getExprString in AbstractOperatorDesc::getColumnExprMapForExplain Key: HIVE-18246 URL: https://issues.apache.org/jira/browse/HIVE-18246 Pro

[jira] [Created] (HIVE-18245) clean up

2017-12-07 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18245: - Summary: clean up Key: HIVE-18245 URL: https://issues.apache.org/jira/browse/HIVE-18245 Project: Hive Issue Type: Sub-task Components: Transacti

Re: checkstyle changes

2017-12-07 Thread Alexander Kolbasov
Problem with 140-wide code isn't just laptops - in many cases we need to do side-by-side diffs (e.g. for code reviews) and this doubles the required size. - Alex. On Thu, Dec 7, 2017 at 1:38 PM, Sergey Shelukhin wrote: > I think the 140-character change will make the code hard to use on a > lap

Re: checkstyle changes

2017-12-07 Thread Sergey Shelukhin
I think the 140-character change will make the code hard to use on a laptop without a monitor. On 17/12/7, 02:43, "Peter Vary" wrote: >Disclaimer: I did not have time to test it out, but according to >http://checkstyle.sourceforge.net/config_misc.html#Indentation >

Re: Review Request 64193: HIVE-18054: Make Lineage work with concurrent queries on a Session

2017-12-07 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64193/#review193155 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRProcContext.

Re: Review Request 64193: HIVE-18054: Make Lineage work with concurrent queries on a Session

2017-12-07 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64193/ --- (Updated Dec. 7, 2017, 7:12 p.m.) Review request for hive. Repository: hive-g

Dataworks Summit EU call for abstracts

2017-12-07 Thread Alan Gates
Dataworks Summit EU 2018 is in Berlin, April 16-19. The call for abstracts is open through December 15th. One of the tracks is Datawarehousing and Operational Data Store, which is a great fit for Hive talks. https://dataworkssummit.com/abstracts/ Alan.

[jira] [Created] (HIVE-18244) CachedStore: Fix UT when CachedStore is enabled

2017-12-07 Thread Vaibhav Gumashta (JIRA)
Vaibhav Gumashta created HIVE-18244: --- Summary: CachedStore: Fix UT when CachedStore is enabled Key: HIVE-18244 URL: https://issues.apache.org/jira/browse/HIVE-18244 Project: Hive Issue Type

[GitHub] hive pull request #274: HIVE-17981 Create a set of builders for Thrift class...

2017-12-07 Thread alanfgates
GitHub user alanfgates opened a pull request: https://github.com/apache/hive/pull/274 HIVE-17981 Create a set of builders for Thrift classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/alanfgates/hive hive17981 Alternatively

[jira] [Created] (HIVE-18243) Cartesian error for joins defined in where clause

2017-12-07 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-18243: --- Summary: Cartesian error for joins defined in where clause Key: HIVE-18243 URL: https://issues.apache.org/jira/browse/HIVE-18243 Project: Hive Issue Ty

Re: checkstyle changes

2017-12-07 Thread Peter Vary
Disclaimer: I did not have time to test it out, but according to http://checkstyle.sourceforge.net/config_misc.html#Indentation Maybe the indentation could be solved by: lineWrappingIndentation=2 (default 4) forceStrictCondition=fal

Re: checkstyle changes

2017-12-07 Thread Zoltan Haindrich
Hello Eugene! I've looked into doing something with these; but I was not able to relieve the warnings you've mentioned: * the ;// is seems to be not configurable It seems like its handled by the whitespaceafter module; I'm not sure how to allow / after ; * I think that indentation of 4 for m

ptests are stuck

2017-12-07 Thread Zoltan Haindrich
Hello, It's stuck again; but the current state is very interesting: * current build is testing HIVE-18237   https://issues.apache.org/jira/browse/HIVE-18237 * it's currently running for >5 hours * hiveqa have posted ptest results for HIVE-18237 around 4 hours ago! * from the jenkins build consol

Re: Review Request 64358: HIVE-18003 add explicit jdbc connection string args for mappings

2017-12-07 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64358/#review193098 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java Lines