----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64358/#review193098 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java Lines 167 (patched) <https://reviews.apache.org/r/64358/#comment271596> nit: use local variable userName? ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java Lines 133 (patched) <https://reviews.apache.org/r/64358/#comment271599> nit: can be combined in if condition ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java Lines 150 (patched) <https://reviews.apache.org/r/64358/#comment271597> nit: non-static - Prasanth_J On Dec. 6, 2017, 8:03 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64358/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 8:03 p.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 75b77072c6 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java edf93859fe > jdbc/src/java/org/apache/hive/jdbc/Utils.java 855de881e9 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 8795cfcee1 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > 33ee8f791f > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java > dbdbbf25db > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java > c58e4507f2 > > > Diff: https://reviews.apache.org/r/64358/diff/3/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >