Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-26 Thread Daniel Dai
> On Dec. 27, 2016, 6:26 a.m., Thejas Nair wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java, > > line 55 > > > > > > seems better as local to the reycle method, as its not used

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-26 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/ --- (Updated Dec. 27, 2016, 6:55 a.m.) Review request for hive and Thejas Nair. R

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-26 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/#review160135 --- metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeMan

Review Request 55046: HIVE-15390: Orc reader unnecessarily reading stripe footers with hive.optimize.index.filter set to true

2016-12-26 Thread Abhishek Somani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55046/ --- Review request for hive. Repository: hive-git Description --- https://is

[jira] [Created] (HIVE-15513) GroupByOperator should initialize GenericUDAFEvaluator before AggregationBuffer (recurrence of HIVE-697)

2016-12-26 Thread Teruyoshi Zenmyo (JIRA)
Teruyoshi Zenmyo created HIVE-15513: --- Summary: GroupByOperator should initialize GenericUDAFEvaluator before AggregationBuffer (recurrence of HIVE-697) Key: HIVE-15513 URL: https://issues.apache.org/jira/browse/

Review Request 55045: HIVE-15324 : Enable round() function to accept scale argument as non-constants

2016-12-26 Thread Chinna Rao Lalam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55045/ --- Review request for hive, Ashutosh Chauhan and Xuefu Zhang. Repository: hive-git

Review Request 55036: Scale is greater than decimal values trunc(d, s) returns wrong results

2016-12-26 Thread Chinna Rao Lalam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55036/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Descriptio