----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/#review160135 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java (line 55) <https://reviews.apache.org/r/54826/#comment231174> seems better as local to the reycle method, as its not used outside. metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java (line 57) <https://reviews.apache.org/r/54826/#comment231177> trailing whitespaces metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java (line 150) <https://reviews.apache.org/r/54826/#comment231173> how about doing this as part of ReplChangeManager constructor ? That will reduce the number of times this needs to be called. metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java (line 165) <https://reviews.apache.org/r/54826/#comment231175> trailing whitespaces in this change. Shows up in red in the diff. metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java (line 172) <https://reviews.apache.org/r/54826/#comment231176> trailing whitespaces metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java (line 232) <https://reviews.apache.org/r/54826/#comment231167> check for DEBUG enabled, but logging is at INFO level - Thejas Nair On Dec. 23, 2016, 8:29 a.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54826/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2016, 8:29 a.m.) > > > Review request for hive and Thejas Nair. > > > Repository: hive-git > > > Description > ------- > > See HIVE-15448 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b4e89b0 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestReplChangeManager.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 2892da3 > metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 6aca1b7 > > Diff: https://reviews.apache.org/r/54826/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
