Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review147068 --- common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java (li

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147046 --- An Eclipse developer at last. :) Thanks a lot for the patch. I hav

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147043 --- I see, the Eclipse test runs cause more headache than with Intelli

Re: Review Request 51046: Support explain analyze in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51046/#review147033 --- Some nits and minor findings. LGTM, otherwise. Thanks for the patc

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147038 --- pom.xml (lines 1292 - 1297)

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147039 --- Other changes looks good to me. - Prasanth_J On Aug. 26, 2016,

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147035 --- pom.xml (lines 1292 - 1297)

Review Request 51468: HIVE-14532 Enable qtests from IDE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/ --- Review request for hive, Balint Molnar, Lefty Leverenz, and Prasanth_J. Bugs: H

Re: Review Request 51193: HIVE-14358: Add metrics for number of queries executed for each execution engine (mr, spark, tez)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51193/#review147030 --- LGTM. Thanks for the patch. - Gabor Szadovszky On Aug. 18, 2016

[jira] [Created] (HIVE-14657) datediff function produce different results with timestamp and string combination

Anup created HIVE-14657: --- Summary: datediff function produce different results with timestamp and string combination Key: HIVE-14657 URL: https://issues.apache.org/jira/browse/HIVE-14657 Project: Hive

Re: Review Request 51046: Support explain analyze in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51046/ --- (Updated Aug. 26, 2016, 8:28 p.m.) Review request for hive and Ashutosh Chauhan

Re: [DISCUSS] Making storage-api a separately released artifact

For good performance the VectorizedRowBatch doesn't follow "traditional" good object rules -- for better or worse. We made a number of member variables public so they can be accessed directly (e.g. for LongColumnVector the long[] vector is public) and avoid using an interface for faster direct

Re: [DISCUSS] Making storage-api a separately released artifact

Question: Wouldn't be better to move part of the implementations to Orc, Parquet and Avro, and just have some interfaces and basic implementations on Hive? This way we could avoid Orc, Parquet and/or Avro to depend from Hive. I saw this on Parquet where they created a RowBatch class internally and

[jira] [Created] (HIVE-14656) Clean up driver instance in get_splits

Jason Dere created HIVE-14656: - Summary: Clean up driver instance in get_splits Key: HIVE-14656 URL: https://issues.apache.org/jira/browse/HIVE-14656 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-14655) LLAP input format should escape the query string being passed to getSplits()

Jason Dere created HIVE-14655: - Summary: LLAP input format should escape the query string being passed to getSplits() Key: HIVE-14655 URL: https://issues.apache.org/jira/browse/HIVE-14655 Project: Hive

Re: Review Request 51046: Support explain analyze in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51046/ --- (Updated Aug. 26, 2016, 6:56 p.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 51334: HIVE-14404: Allow delimiterfordsv to use multiple-character delimiters - second version

> On Aug. 26, 2016, 5:39 p.m., Gabor Szadovszky wrote: > > Some minor findings/questions. LGTM, otherwise. Thanks for the patch. :) - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/513

Re: Review Request 51334: HIVE-14404: Allow delimiterfordsv to use multiple-character delimiters - second version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51334/#review146985 --- Some minor findings/questions. LGTM, otherwise. beeline/src/java

[jira] [Created] (HIVE-14654) Enable support for binary and blob datatypes

Akshay created HIVE-14654: - Summary: Enable support for binary and blob datatypes Key: HIVE-14654 URL: https://issues.apache.org/jira/browse/HIVE-14654 Project: Hive Issue Type: Improvement

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

> On Aug. 26, 2016, 2:01 a.m., Siddharth Seth wrote: > > Not a lot here related to the patch itself in this comment. > > Looks like everyone has gotten interested in fixing Hive tests at about the > > same time - and there's a good reason for that :) > > I think it would be better to get changes

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/ --- (Updated Aug. 26, 2016, 12:23 p.m.) Review request for hive, Ashutosh Chauhan,

[jira] [Created] (HIVE-14653) week value is different between weekofyear(date) and date_format(date, "ww")

Shawn Zhou created HIVE-14653: - Summary: week value is different between weekofyear(date) and date_format(date, "ww") Key: HIVE-14653 URL: https://issues.apache.org/jira/browse/HIVE-14653 Project: Hive

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

> On Aug. 26, 2016, 2:01 a.m., Siddharth Seth wrote: > > Not a lot here related to the patch itself in this comment. > > Looks like everyone has gotten interested in fixing Hive tests at about the > > same time - and there's a good reason for that :) > > I think it would be better to get changes