----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review147068 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java (line 72) <https://reviews.apache.org/r/51435/#comment214066> hive.conf.hidden.list is usually not default specified in configurations (e.g. that from hdfs-site.xml) other than HiveConf, so the hiddenListStr should be retruned as null for these configuraitons, and the properties listed in HiveConf hidden list are still not able to be stripped from this Config, right? The S3 credentials I think could be defined in the hdfs configuration but they are specified in HiveConf hiddenList, they should be stripped and have we tested them? - Chaoyu Tang On Aug. 25, 2016, 8:36 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51435/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 8:36 p.m.) > > > Review request for hive, Chaoyu Tang, Gabor Szadovszky, Sergio Pena, and > Barna Zsombor Klara. > > > Bugs: HIVE-14426 > https://issues.apache.org/jira/browse/HIVE-14426 > > > Repository: hive-git > > > Description > ------- > > Used HiveConf.stripHiddenConfigurations to remove sensitive information from > configuration dump. Had to refactor, so it could be applied to simple > Configuration objects too, like AppConfig. > > Used Utilities.maskIfPassword to remove sensitive information from property > dump > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 14a538b > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 073a978 > > hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonUtils.java > 201e647 > > Diff: https://reviews.apache.org/r/51435/diff/ > > > Testing > ------- > > Manually - checked both > > > Thanks, > > Peter Vary > >
