Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

2016-06-14 Thread Takanobu Asanuma
> On 6月 3, 2016, 5:50 p.m., Vaibhav Gumashta wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java, > > line 157 > > > > > > Can you add a test with a join query as well? The join qu

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

2016-06-14 Thread Takanobu Asanuma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 6月 15, 2016, 6:50 a.m.) Review request for hive. Changes --- I

Re: Review Request 48716: HIVE-13873 Column pruning for nested fields

2016-06-14 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48716/ --- (Updated June 15, 2016, 11:34 a.m.) Review request for hive and Xuefu Zhang.

Review Request 48716: HIVE-13873

2016-06-14 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48716/ --- Review request for hive and Xuefu Zhang. Bugs: HIVE-13873 https://issues.ap

[jira] [Created] (HIVE-14016) Vectorization: VectorGroupByRollupOperator and VectorGroupByCubeOperator

2016-06-14 Thread Gopal V (JIRA)
Gopal V created HIVE-14016: -- Summary: Vectorization: VectorGroupByRollupOperator and VectorGroupByCubeOperator Key: HIVE-14016 URL: https://issues.apache.org/jira/browse/HIVE-14016 Project: Hive Is

Re: Review Request 48520: Use multi-threaded approach to listing files for msck

2016-06-14 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review137639 --- Ship it! Ship It! - Prasanth_J On June 15, 2016, 12:24 a.m.,

Re: Review Request 48520: Use multi-threaded approach to listing files for msck

2016-06-14 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/ --- (Updated June 15, 2016, 12:24 a.m.) Review request for hive and Hari Sankar Siv

[jira] [Created] (HIVE-14015) SMB MapJoin failed for Hive on Spark when kerberized

2016-06-14 Thread Yongzhi Chen (JIRA)
Yongzhi Chen created HIVE-14015: --- Summary: SMB MapJoin failed for Hive on Spark when kerberized Key: HIVE-14015 URL: https://issues.apache.org/jira/browse/HIVE-14015 Project: Hive Issue Type: B

Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Ashutosh Chauhan
No patch doesn't do that in reverse. You may read my comments on jira. I think we should leave this patch in and do a follow-up jira for the change I suggested in previous email (and in jira comments). On Tue, Jun 14, 2016 at 4:20 PM, Sergey Shelukhin wrote: > Doesn’t the patch in question do th

Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Sergey Shelukhin
Doesn’t the patch in question do the reverse? I think we can have a follow-up JIRA if it’s not already done in all circumstances, without the patch. On 16/6/14, 16:13, "Ashutosh Chauhan" wrote: >What about my suggestions to treat non-integral constant literals as >BigDecimal instead of Double? I

Re: Review Request 48656: HIVE-13958: Support prohibiting string to decimal auto-casts.

2016-06-14 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48656/#review137610 --- ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDes

Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Ashutosh Chauhan
What about my suggestions to treat non-integral constant literals as BigDecimal instead of Double? I checked on other products and thats what MySQL, Oracle & SQL server is doing. Thanks, Ashutosh On Tue, Jun 14, 2016 at 4:07 PM, Alan Gates wrote: > I’m +1 on reverting it. Let’s not change arou

Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Alan Gates
I’m +1 on reverting it. Let’s not change around functionality on our users and let’s stay as close as possible to the standard, both of which reverting this seems to do. Alan. > On Jun 10, 2016, at 16:07, Sergey Shelukhin wrote: > > There has recently been a change in behavior in Hive wrt do

Re: Review Request 48656: HIVE-13958: Support prohibiting string to decimal auto-casts.

2016-06-14 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48656/#review137612 --- ql/src/test/queries/clientnegative/compare_double_bigint_between.

Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Sergey Shelukhin
I am overwhelmed by the response ;) If there are no objections I’m going to revert the patch also from master tomorrow. On 16/6/10, 16:07, "Sergey Shelukhin" wrote: >There has recently been a change in behavior in Hive wrt doubles and >decimals, HIVE-13380; where the literals were changed to be

Re: Review Request 47735: HIVE-13617 LLAP: support non-vectorized execution in IO

2016-06-14 Thread Sergey Shelukhin
> On May 23, 2016, 10:37 p.m., Matt McCline wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/BatchToRowReader.java, line 181 > > > > > > The VectorExtractRow class and extractRowColumn method has similar > > func

[jira] [Created] (HIVE-14014) zero length file is being created for empty bucket in tez mode (II)

2016-06-14 Thread Pengcheng Xiong (JIRA)
Pengcheng Xiong created HIVE-14014: -- Summary: zero length file is being created for empty bucket in tez mode (II) Key: HIVE-14014 URL: https://issues.apache.org/jira/browse/HIVE-14014 Project: Hive

[jira] [Created] (HIVE-14013) Describe table doesn't show unicode properly

2016-06-14 Thread Aihua Xu (JIRA)
Aihua Xu created HIVE-14013: --- Summary: Describe table doesn't show unicode properly Key: HIVE-14013 URL: https://issues.apache.org/jira/browse/HIVE-14013 Project: Hive Issue Type: Bug Com

[jira] [Created] (HIVE-14012) some ColumnVector-s are missing ensureSize

2016-06-14 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14012: --- Summary: some ColumnVector-s are missing ensureSize Key: HIVE-14012 URL: https://issues.apache.org/jira/browse/HIVE-14012 Project: Hive Issue Type: Bug

Re: Review Request 48159: HIVE-13901: Hivemetastore add partitions can be slow depending on filesystems

2016-06-14 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48159/#review137561 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore

[jira] [Created] (HIVE-14011) MessageFactory is not pluggable

2016-06-14 Thread Sravya Tirukkovalur (JIRA)
Sravya Tirukkovalur created HIVE-14011: -- Summary: MessageFactory is not pluggable Key: HIVE-14011 URL: https://issues.apache.org/jira/browse/HIVE-14011 Project: Hive Issue Type: Bug

Re: Review Request 48520: Use multi-threaded approach to listing files for msck

2016-06-14 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review137453 --- Mostly looks good. Some minor comments. ql/src/java/org/apache/h

[jira] [Created] (HIVE-14010) parquet-logging.properties from HIVE_CONF_DIR should be used when available

2016-06-14 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-14010: Summary: parquet-logging.properties from HIVE_CONF_DIR should be used when available Key: HIVE-14010 URL: https://issues.apache.org/jira/browse/HIVE-14010