----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review137453 -----------------------------------------------------------
Mostly looks good. Some minor comments. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 373) <https://reviews.apache.org/r/48520/#comment202595> synchronizedSet will be slow because of global mutex. Use ConcurrentHashMap and ignore the values instead? ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 378) <https://reviews.apache.org/r/48520/#comment202592> nit: Better to put the context in the thread name. MSCK-GetPaths-%d? ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 389) <https://reviews.apache.org/r/48520/#comment202598> LOG.debug here to say we are using/not-using threaded version of the code along with number of threads used. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 436) <https://reviews.apache.org/r/48520/#comment202596> use LOG.error here? ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 441) <https://reviews.apache.org/r/48520/#comment202599> nit: if (!nextLevel.isEmpty()) { .. recurse } s - Prasanth_J On June 13, 2016, 4:57 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48520/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 4:57 p.m.) > > > Review request for hive and Hari Sankar Sivarama Subramaniyan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13984 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 10fa561 > > Diff: https://reviews.apache.org/r/48520/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
