Re: Review Request 38503: Support special characters in quoted table names

2015-10-02 Thread Lefty Leverenz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38503/#review101399 --- Ship it! Ship It! - Lefty Leverenz On Oct. 2, 2015, 12:03 p.m.,

Re: unit tests in patches

2015-10-02 Thread Szehon Ho
Hi all, HiveQA now gives +1/-1 review based on presence/absence of added or modified unit tests, like HadoopQA. Obviously not always possible, but this should be fulfilled to best effort. Thanks, Szehon On Tue, Sep 22, 2015 at 5:37 PM, Sushanth Sowmyan wrote: > +1 to Siddharth's suggestion -

Re: Review Request 38503: Support special characters in quoted table names

2015-10-02 Thread Lefty Leverenz
> On Sept. 29, 2015, 11:33 p.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2176-2177 > > > > > > Looks good, thanks! > > > > But would you please change th

Re: Review Request 38969: HIVE-11777 implement an option to have single ETL strategy for multiple directories

2015-10-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38969/#review101388 --- ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (

Re: Review Request 38969: HIVE-11777 implement an option to have single ETL strategy for multiple directories

2015-10-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38969/ --- (Updated Oct. 2, 2015, 10:42 p.m.) Review request for hive and Gopal V. Summa

Review Request 38968: HIVE-11856 allow split strategies to run on threadpool

2015-10-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38968/ --- Review request for hive and Prasanth_J. Repository: hive-git Description

[jira] [Created] (HIVE-12027) simplify file metadata cache ppd api

2015-10-02 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-12027: --- Summary: simplify file metadata cache ppd api Key: HIVE-12027 URL: https://issues.apache.org/jira/browse/HIVE-12027 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-12026) Add test case to check permissions when truncating partition

2015-10-02 Thread Jason Dere (JIRA)
Jason Dere created HIVE-12026: - Summary: Add test case to check permissions when truncating partition Key: HIVE-12026 URL: https://issues.apache.org/jira/browse/HIVE-12026 Project: Hive Issue Ty

Re: Review Request 38783: HIVE-11969 start Tez session in background when starting CLI

2015-10-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38783/ --- (Updated Oct. 2, 2015, 9:10 p.m.) Review request for hive, Gunther Hagleitner a

Re: Review Request 38838: HIVE-11913 : Verify existence of tests for new changes in HiveQA

2015-10-02 Thread Szehon Ho
> On Oct. 2, 2015, 7:44 p.m., Sergio Pena wrote: > > The patch looks good. > > I just saw many lines that were not changed are shown with green/yellow > > lines. Could it be because spaces? Hi yea, as I mentioned, I used the codestyle. Yes they are spaces. At first it wasn't intentional, but

Re: Review Request 38838: HIVE-11913 : Verify existence of tests for new changes in HiveQA

2015-10-02 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38838/#review101360 --- Ship it! The patch looks good. I just saw many lines that were not

[jira] [Created] (HIVE-12025) refactor bucketId generating code

2015-10-02 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-12025: - Summary: refactor bucketId generating code Key: HIVE-12025 URL: https://issues.apache.org/jira/browse/HIVE-12025 Project: Hive Issue Type: Bug Co

[jira] [Created] (HIVE-12024) javaXML serialization fails to serialize ReduceWork

2015-10-02 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-12024: Summary: javaXML serialization fails to serialize ReduceWork Key: HIVE-12024 URL: https://issues.apache.org/jira/browse/HIVE-12024 Project: Hive

Re: Review Request 38503: Support special characters in quoted table names

2015-10-02 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38503/ --- (Updated Oct. 2, 2015, 7:03 p.m.) Review request for hive, Ashutosh Chauhan and

[jira] [Created] (HIVE-12023) add option to explain optimizer(s) behavior

2015-10-02 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-12023: --- Summary: add option to explain optimizer(s) behavior Key: HIVE-12023 URL: https://issues.apache.org/jira/browse/HIVE-12023 Project: Hive Issue Type: Bu

[jira] [Created] (HIVE-12022) NPE in SARG with timestamp cast

2015-10-02 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-12022: Summary: NPE in SARG with timestamp cast Key: HIVE-12022 URL: https://issues.apache.org/jira/browse/HIVE-12022 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-12021) HivePreFilteringRule may introduce wrong common operands

2015-10-02 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created HIVE-12021: -- Summary: HivePreFilteringRule may introduce wrong common operands Key: HIVE-12021 URL: https://issues.apache.org/jira/browse/HIVE-12021 Project: Hi

[jira] [Created] (HIVE-12020) Revert log4j2 xml configuration to properties based configuration

2015-10-02 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-12020: Summary: Revert log4j2 xml configuration to properties based configuration Key: HIVE-12020 URL: https://issues.apache.org/jira/browse/HIVE-12020 Proje

[jira] [Created] (HIVE-12019) Create unit test for HIVE-10732

2015-10-02 Thread Jason Dere (JIRA)
Jason Dere created HIVE-12019: - Summary: Create unit test for HIVE-10732 Key: HIVE-12019 URL: https://issues.apache.org/jira/browse/HIVE-12019 Project: Hive Issue Type: Bug Components:

Re: Review Request 38503: Support special characters in quoted table names

2015-10-02 Thread pengcheng xiong
> On Sept. 30, 2015, 6:33 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2176-2177 > > > > > > Looks good, thanks! > > > > But would you please change the

[jira] [Created] (HIVE-12018) beeline --help doesn't return to original prompt

2015-10-02 Thread Mohammad Kamrul Islam (JIRA)
Mohammad Kamrul Islam created HIVE-12018: Summary: beeline --help doesn't return to original prompt Key: HIVE-12018 URL: https://issues.apache.org/jira/browse/HIVE-12018 Project: Hive

[jira] [Created] (HIVE-12017) Do not disable CBO by default when number of joins in a query is equal or less than 1

2015-10-02 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created HIVE-12017: -- Summary: Do not disable CBO by default when number of joins in a query is equal or less than 1 Key: HIVE-12017 URL: https://issues.apache.org/jira/browse/HIVE-

Re: Review Request 38503: Support special characters in quoted table names

2015-10-02 Thread Lefty Leverenz
> On Sept. 29, 2015, 11:33 p.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2176-2177 > > > > > > Looks good, thanks! > > > > But would you please change th