> On Sept. 29, 2015, 11:33 p.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2176-2177 > > <https://reviews.apache.org/r/38503/diff/1-2/?file=1076829#file1076829line2176> > > > > Looks good, thanks! > > > > But would you please change the line breaks to conform to the 100-char > > limit? (It's a cosmetic issue for the template file.) > > > > Aaarrgh, forgot to publish this review. Oh well, better late than > > never.
Line 2176 is still too long, and there's no newline char at the end so in the template file the description in lines 2176 and 2177 will run together as a single line. Please split line 2176 before "[a-zA-z" ... oh, and shouldn't it be "[a-zA-Z" (capital Z after capital A)? - Lefty ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38503/#review100159 ----------------------------------------------------------- On Sept. 30, 2015, 2:57 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38503/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2015, 2:57 p.m.) > > > Review request for hive, Ashutosh Chauhan and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > Right now table names can only be "[a-zA-z_0-9]+". This patch tries to > investigate how much change there should be if we would like to support > special characters, e.g., "/" in table names. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > ee20430 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > a80f686 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > f88f4dd > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java > 4966d89 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 8b7a2e8 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa > ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q > PRE-CREATION > ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q > PRE-CREATION > ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q > PRE-CREATION > ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q > PRE-CREATION > ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/38503/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
