Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

2015-06-09 Thread cheng xu
> On June 9, 2015, 12:41 p.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beel

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

2015-06-09 Thread cheng xu
> On June 9, 2015, 12:41 p.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beel

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

2015-06-09 Thread Xuefu Zhang
> On June 9, 2015, 4:41 a.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beeli

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

2015-06-09 Thread cheng xu
> On June 9, 2015, 12:41 p.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beel

[jira] [Created] (HIVE-10974) Use Cofiguration::getRaw() for the Base64 data

2015-06-09 Thread Gopal V (JIRA)
Gopal V created HIVE-10974: -- Summary: Use Cofiguration::getRaw() for the Base64 data Key: HIVE-10974 URL: https://issues.apache.org/jira/browse/HIVE-10974 Project: Hive Issue Type: Bug Com

[jira] [Created] (HIVE-10973) JvmPauseMonitor.incrementMetricsCounter NPE while starting HiveServer2

2015-06-09 Thread Hari Sankar Sivarama Subramaniyan (JIRA)
Hari Sankar Sivarama Subramaniyan created HIVE-10973: Summary: JvmPauseMonitor.incrementMetricsCounter NPE while starting HiveServer2 Key: HIVE-10973 URL: https://issues.apache.org/jira/browse/

Re: Review Request 35256: HIVE-10956 HS2 leaks HMS connections

2015-06-09 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35256/ --- (Updated June 9, 2015, 8:54 p.m.) Review request for hive and Xuefu Zhang. Re

Re: Review Request 35256: HIVE-10956 HS2 leaks HMS connections

2015-06-09 Thread Jimmy Xiang
> On June 9, 2015, 8:52 p.m., Xuefu Zhang wrote: > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, > > line 596 > > > > > > If this requires synchronization, I guess the whole method will

Re: Review Request 35256: HIVE-10956 HS2 leaks HMS connections

2015-06-09 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35256/#review87291 --- service/src/java/org/apache/hive/service/cli/session/HiveSessionImp

[jira] [Created] (HIVE-10972) DummyTxnManager always locks the current database in shared mode, which is incorrect.

2015-06-09 Thread Aihua Xu (JIRA)
Aihua Xu created HIVE-10972: --- Summary: DummyTxnManager always locks the current database in shared mode, which is incorrect. Key: HIVE-10972 URL: https://issues.apache.org/jira/browse/HIVE-10972 Project: Hi

Review Request 35256: HIVE-10956 HS2 leaks HMS connections

2015-06-09 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35256/ --- Review request for hive and Xuefu Zhang. Repository: hive-git Description ---

Re: Review Request 35218: HIVE-10963 Hive throws NPE rather than meaningful error message when window is missing

2015-06-09 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35218/ --- (Updated June 9, 2015, 2:40 p.m.) Review request for hive. Repository: hive-g

Re: Review Request 35181: HIVE-10944 : Fix HS2 for Metrics

2015-06-09 Thread Lenni Kuff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35181/#review87169 --- Ship it! - Lenni Kuff On June 7, 2015, 11:47 p.m., Szehon Ho wrot

Re: Review Request 35181: HIVE-10944 : Fix HS2 for Metrics

2015-06-09 Thread Lenni Kuff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35181/#review87168 --- service/src/java/org/apache/hive/service/server/HiveServer2.java

[jira] [Created] (HIVE-10971) count(*) with count(distinct) gives wrong results when hive.groupby.skewindata=true

2015-06-09 Thread wangmeng (JIRA)
wangmeng created HIVE-10971: --- Summary: count(*) with count(distinct) gives wrong results when hive.groupby.skewindata=true Key: HIVE-10971 URL: https://issues.apache.org/jira/browse/HIVE-10971 Project: Hive