> On June 9, 2015, 8:52 p.m., Xuefu Zhang wrote: > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, > > line 596 > > <https://reviews.apache.org/r/35256/diff/1/?file=981540#file981540line596> > > > > If this requires synchronization, I guess the whole method will need to > > be synchronized. I can see the code above accessing shared member variables.
Sure. Will synchronize the whole method, to be safe. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35256/#review87291 ----------------------------------------------------------- On June 9, 2015, 5 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35256/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 5 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Repository: hive-git > > > Description > ------- > > Share the HMS connection per HS2 session, and close it when the session is > closed. > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > f5816a0 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 8c948a9 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 33ee16b > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 65f9b29 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 343c68e > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > a29e5d1 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 5a0f1c8 > > Diff: https://reviews.apache.org/r/35256/diff/ > > > Testing > ------- > > Live cluster > > > Thanks, > > Jimmy Xiang > >
