Re: [PR] h2: add choosing framefactory impl [httpcomponents-core]

2025-06-08 Thread via GitHub
ok2c commented on code in PR #525: URL: https://github.com/apache/httpcomponents-core/pull/525#discussion_r2134821163 ## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2RequesterBootstrap.java: ## @@ -303,6 +305,16 @@ public final H2RequesterBootstrap

[PR] h2: add choosing framefactory impl [httpcomponents-core]

2025-06-08 Thread via GitHub
psmarko opened a new pull request, #525: URL: https://github.com/apache/httpcomponents-core/pull/525 The FrameFactory interface is useful as, for example, it allows patching in PRIORITY support and changing frame values that are not generally configurable. It is set to the default impl in C

Re: [PR] h2: add choosing framefactory impl [httpcomponents-core]

2025-06-08 Thread via GitHub
garydgregory commented on PR #525: URL: https://github.com/apache/httpcomponents-core/pull/525#issuecomment-2954144187 Hello @psmarko Please add unit test that cover the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G