ok2c commented on code in PR #525:
URL:
https://github.com/apache/httpcomponents-core/pull/525#discussion_r2134821163
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2RequesterBootstrap.java:
##########
@@ -303,6 +305,16 @@ public final H2RequesterBootstrap setUriPatternType(final
UriPatternType uriPatt
return this;
}
+ /**
Review Comment:
@psmarko This is a good start. Please add `@since 5.4` tag to this method.
There should also be a similar setter added to
`H2MultiplexingRequesterBootstrap` and `H2ServerBootstrap`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
