Re: [PR] Use a random boundary value by default [httpcomponents-client]

2025-03-18 Thread via GitHub
ok2c commented on code in PR #625: URL: https://github.com/apache/httpcomponents-client/pull/625#discussion_r2000700396 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java: ## @@ -47,18 +47,8 @@ /** * Builder for multipart {@link H

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-18 Thread via GitHub
ok2c commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2733170480 > The problem with this is that the user may be on an old version and it may be onerous for them to upgrade to the latest one just so that my SDK can call this withRandomBoundar

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-18 Thread via GitHub
TomerAberbach commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2733046088 > @TomerAberbach Maven dependency resolver should pick version 5.5 over 5.4 if both are present as transitive dependencies. (Please @michael-o correct me if I am wrong.

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-18 Thread via GitHub
ok2c commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2732566977 @TomerAberbach Maven dependency resolver should pick version 5.5 over 5.4 if both are present as transitive dependencies. (Please @michael-o correct me if I am wrong.) If the us

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-18 Thread via GitHub
ok2c commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2732961267 > I don't know whether this is really necessary. The MIME package here covers a lot of cases, I don't see a reason why it should not continue to do s @michael-o And who de

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-18 Thread via GitHub
michael-o commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2732607115 > @TomerAberbach Maven dependency resolver should pick version 5.5 over 5.4 if both are present as transitive dependencies. (Please @michael-o correct me if I am wrong.) If

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-18 Thread via GitHub
michael-o commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2731794175 I'd rather make it random and move it. Not worth the pain or reduction of the computational overhead. -- This is an automated message from the Apache Git Service. To res

Re: [PR] Use a random boundary value by default [httpcomponents-client]

2025-03-18 Thread via GitHub
ok2c commented on code in PR #625: URL: https://github.com/apache/httpcomponents-client/pull/625#discussion_r2000702616 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java: ## @@ -234,14 +225,12 @@ public MultipartEntityBuilder addBin